Skip to content

[libc][math][c23] Fix setpayloadsig smoke test on RV32 #102538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from Aug 9, 2024
Merged

[libc][math][c23] Fix setpayloadsig smoke test on RV32 #102538

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
76d0424
fix bug
Aug 8, 2024
6c89a05
format code
Aug 8, 2024
924c032
address review
Aug 8, 2024
98d2080
format code
Aug 8, 2024
7918594
address review
Aug 9, 2024
3634aff
format code
Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions libc/test/src/math/smoke/SetPayloadSigTest.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,13 @@ class SetPayloadSigTestTemplate : public LIBC_NAMESPACE::testing::FEnvSafeTest {
EXPECT_EQ(1, func(&res, T(-1.0)));
EXPECT_EQ(1, func(&res, T(0x42.1p+0)));
EXPECT_EQ(1, func(&res, T(-0x42.1p+0)));
EXPECT_EQ(1, func(&res, T(StorageType(1) << (FPBits::FRACTION_LEN - 1))));

FPBits default_snan_payload_bits = FPBits::one();
default_snan_payload_bits.set_biased_exponent(FPBits::FRACTION_LEN - 1 +
FPBits::EXP_BIAS);
T default_snan_payload = default_snan_payload_bits.get_val();

EXPECT_EQ(1, func(&res, default_snan_payload));
}

void testValidPayloads(SetPayloadSigFunc func) {
Expand All @@ -56,7 +62,12 @@ class SetPayloadSigTestTemplate : public LIBC_NAMESPACE::testing::FEnvSafeTest {
EXPECT_EQ(FPBits::signaling_nan(Sign::POS, 0x123).uintval(),
FPBits(res).uintval());

EXPECT_EQ(0, func(&res, T(FPBits::FRACTION_MASK >> 1)));
FPBits nan_payload_bits = FPBits::one();
nan_payload_bits.set_biased_exponent(FPBits::FRACTION_LEN - 2 +
FPBits::EXP_BIAS);
nan_payload_bits.set_mantissa(FPBits::SIG_MASK - 3);
T nan_payload = nan_payload_bits.get_val();
EXPECT_EQ(0, func(&res, nan_payload));
EXPECT_TRUE(FPBits(res).is_signaling_nan());
EXPECT_EQ(
FPBits::signaling_nan(Sign::POS, FPBits::FRACTION_MASK >> 1).uintval(),
Expand Down
Loading