[CMake] Followup to #102396 and restore old DynamicLibrary symbols behavior #102671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5
|
@llvm/pr-subscribers-llvm-support Author: Steven Wu (cachemeifyoucan) ChangesFollowup to #102138 and #102396, restore more old behavior to fix Full diff: https://github.com/llvm/llvm-project/pull/102671.diff 1 Files Affected:
diff --git a/llvm/unittests/Support/DynamicLibrary/CMakeLists.txt b/llvm/unittests/Support/DynamicLibrary/CMakeLists.txt
index d8dff1ef4a3f77..e976cba23ee8cf 100644
--- a/llvm/unittests/Support/DynamicLibrary/CMakeLists.txt
+++ b/llvm/unittests/Support/DynamicLibrary/CMakeLists.txt
@@ -17,10 +17,9 @@ set_output_directory(DynamicLibraryLib
add_llvm_unittest(DynamicLibraryTests
DynamicLibraryTest.cpp
-
- EXPORT_SYMBOLS
)
target_link_libraries(DynamicLibraryTests PRIVATE DynamicLibraryLib)
+export_executable_symbols(DynamicLibraryTests)
function(dynlib_add_module NAME)
add_library(${NAME} MODULE
|
cachemeifyoucan
deleted the
users/cachemeifyoucan/spr/cmake-followup-to-102396-and-restore-old-dynamiclibrary-symbols-behavior
branch
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/2737 Here is the relevant piece of the build log for the reference: |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/418 Here is the relevant piece of the build log for the reference: |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/52/builds/1524 Here is the relevant piece of the build log for the reference: |
|
Reverted. As this makes few other bots failure and didn't fix the ppc64 bot. |
|
It did fix the ppc64 bot https://lab.llvm.org/buildbot/#/builders/64/builds/668. Would it make sense to guard this PR for AIX only, as a temporary fix, then we'll investigate the difference further? EDIT: never mind, I see you have a second fix. |
cachemeifyoucan
added a commit
that referenced
this pull request
Aug 13, 2024
Reland #102671 after the other attempted fixes are all flawed in some build configurations. The previous try for the same commit was breaking a flaky tests under ASAN which is not marked as unsupported. This fix should be good to go now. Fixes AIX bot for DynamicLibraryTests failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #102138 and #102396, restore more old behavior to fix
ppc64-aix bot.