Skip to content

[Interp] Mark the test unsupported with Asan #102859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

vitalybuka
Copy link
Collaborator

@vitalybuka vitalybuka commented Aug 12, 2024

It's very flaky recently.

10 bulds are OK, then 3 failed:
https://lab.llvm.org/buildbot/#/builders/52/builds/1524
https://lab.llvm.org/buildbot/#/builders/52/builds/1525
https://lab.llvm.org/buildbot/#/builders/52/builds/1526
then 3 OK
https://lab.llvm.org/buildbot/#/builders/52/builds/1531
https://lab.llvm.org/buildbot/#/builders/52/builds/1532
then 2 green again

We need to stop to spam blame list by disabling the test,
and investigate later if Asan is valuable for the test.

Issue #102858

Created using spr 1.3.4
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Aug 12, 2024
@vitalybuka vitalybuka requested a review from hahnjo August 12, 2024 07:43
@llvmbot
Copy link
Member

llvmbot commented Aug 12, 2024

@llvm/pr-subscribers-clang

Author: Vitaly Buka (vitalybuka)

Changes

It's very flaky recently.

Issue #102858


Full diff: https://github.com/llvm/llvm-project/pull/102859.diff

1 Files Affected:

  • (modified) clang/test/Interpreter/const.cpp (+3)
diff --git a/clang/test/Interpreter/const.cpp b/clang/test/Interpreter/const.cpp
index 57fd880400e6a1..6cafc777c626e7 100644
--- a/clang/test/Interpreter/const.cpp
+++ b/clang/test/Interpreter/const.cpp
@@ -2,6 +2,9 @@
 // see https://github.com/llvm/llvm-project/issues/68092
 // XFAIL: host={{.*}}-windows-msvc
 
+// The test is flaky with asan.
+// UNSUPPORTED: asan
+
 // RUN: cat %s | clang-repl | FileCheck %s
 // RUN: cat %s | clang-repl -Xcc -O2 | FileCheck %s
 

@vitalybuka vitalybuka requested a review from yronglin August 12, 2024 07:43
@hahnjo
Copy link
Member

hahnjo commented Aug 12, 2024

Quick question for my understanding: With spr we don't get meaningful commit messages anymore? That's quite unfortunate...

@vitalybuka
Copy link
Collaborator Author

vitalybuka commented Aug 12, 2024

Quick question for my understanding: With spr we don't get meaningful commit messages anymore? That's quite unfortunate...

Can you please clarify?

If I understand you questing correctly, then nothing is special about spr, it puts what ever was in the commit.

If this cryptic request for more details :), then my preference to keep details in the issue, I don't see value in noise from pasted errors into commit log.

Added some details, but I don't really have much to add, and build links will expire in a couple of weeks.

Copy link
Contributor

@yronglin yronglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hahnjo
Copy link
Member

hahnjo commented Aug 13, 2024

Quick question for my understanding: With spr we don't get meaningful commit messages anymore? That's quite unfortunate...

Can you please clarify?

The commit messages in this PR are initial version and Update const.cpp, which is totally useless if I came across this in git log. I meanwhile remembered that the policy in LLVM is to squash-and-merge, so I guess you can supply a more useful message at that point, but I would still argue that the history deserves better than what is currently in this PR.

@vitalybuka
Copy link
Collaborator Author

vitalybuka commented Aug 13, 2024

Quick question for my understanding: With spr we don't get meaningful commit messages anymore? That's quite unfortunate...

Can you please clarify?

The commit messages in this PR are initial version and Update const.cpp, which is totally useless if I came across this in git log. I meanwhile remembered that the policy in LLVM is to squash-and-merge, so I guess you can supply a more useful message at that point, but I would still argue that the history deserves better than what is currently in this PR.

LLVM repo does not allow "merge" or "rebase", everything is squash, with ONLY commit message created from the description of the PR.
With or without spr internal PR commits description are irrelevant.

@vitalybuka
Copy link
Collaborator Author

@hahnjo I believe I explained "Update const.cpp" issue.
So I am going to merge as the that continue to sporadically brake.

@vitalybuka vitalybuka merged commit ba40053 into main Aug 13, 2024
8 checks passed
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/interp-mark-the-test-unsupported-with-asan branch August 13, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants