[GitHub] Run format job on stacked PRs #102957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the formatter only runs on the main branch, which prevents the formatter from running for stacked PRs, which have to target user branches instead of main. Disclaimer: I have never touched GH actions before and I don't know if this is correct, but this seemed like a simple fix. If this is completely wrong, feel free to close and I can file an issue instead.
|
@llvm/pr-subscribers-github-workflow Author: Tobias Stadler (tobias-stadler) ChangesCurrently the formatter only runs on the main branch, which prevents the formatter from running for stacked PRs, which have to target user branches instead of main. Disclaimer: I have never touched GH actions before and I don't know if this is correct, but this seemed like a simple fix. If this is completely wrong, feel free to close and I can file an issue instead. Full diff: https://github.com/llvm/llvm-project/pull/102957.diff 1 Files Affected:
diff --git a/.github/workflows/pr-code-format.yml b/.github/workflows/pr-code-format.yml
index 22357e5d99e4c..6b588f19e307b 100644
--- a/.github/workflows/pr-code-format.yml
+++ b/.github/workflows/pr-code-format.yml
@@ -7,6 +7,7 @@ on:
pull_request:
branches:
- main
+ - 'users/**'
jobs:
code_formatter:
|
qiaojbao
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Aug 29, 2024
…f3eb12095 Local branch amd-gfx a22f3eb Merged main:6de04e6fe8b1520ef3e4073ff222e623b7dc9cb9 into amd-gfx:697d8fbeaade Remote branch main 9811971 [GitHub] Run format job on stacked PRs (llvm#102957)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the formatter only runs for the main branch, which prevents the formatter from running for stacked PRs, which have to target user branches instead of main.
Disclaimer: I have never touched GH actions before, but this seemed like a simple fix. If this is completely wrong, feel free to close and I can file an issue instead.