Skip to content

[ubsan] Limit _BitInt ubsan tests to x86-64 platform only #104494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 15, 2024
Merged

[ubsan] Limit _BitInt ubsan tests to x86-64 platform only #104494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
98d3d53
[ubsan] Display correct runtime messages for negative _BitInt
Aug 7, 2024
2ba516a
Merge branch 'llvm:main' into main
earnol Aug 15, 2024
4de0f7e
[bitint] Fix test error due to CRT dependency
Aug 15, 2024
0f15cfb
[test] Update CodeGen/bit-int-ubsan to invoke only frontend
Aug 15, 2024
0c2cbba
[ubsan] Limit runtime tests to x86-64 target only
Aug 15, 2024
5adf01b
Update bit-int.c
vitalybuka Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 2 additions & 20 deletions clang/test/CodeGen/bit-int-ubsan.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
// REQUIRES: x86-registered-target
// RUN: %clang -Wno-constant-conversion -Wno-array-bounds -Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative -Wno-int-to-pointer-cast -fsanitize=array-bounds,enum,float-cast-overflow,integer-divide-by-zero,implicit-unsigned-integer-truncation,implicit-signed-integer-truncation,implicit-integer-sign-change,unsigned-integer-overflow,signed-integer-overflow,shift-base,shift-exponent -O0 -S -emit-llvm -o - %s | FileCheck %s
// RUN: %clang_cc1 -Wno-constant-conversion -Wno-array-bounds -Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative -Wno-int-to-pointer-cast -fsanitize=array-bounds,enum,float-cast-overflow,integer-divide-by-zero,implicit-unsigned-integer-truncation,implicit-signed-integer-truncation,implicit-integer-sign-change,unsigned-integer-overflow,signed-integer-overflow,shift-base,shift-exponent -O0 -emit-llvm -o - %s | FileCheck %s

// The runtime test checking the _BitInt ubsan feature is located in compiler-rt/test/ubsan/TestCases/Integer/bit-int.c

#include <stdint.h>
#include <stdio.h>

typedef unsigned int uint32_t;
uint32_t float_divide_by_zero() {
float f = 1.0f / 0.0f;
// CHECK: constant { i16, i16, [8 x i8] } { i16 1, i16 32, [8 x i8] c"'float'\00" }
Expand Down Expand Up @@ -78,19 +76,3 @@ uint32_t negative_shift5(unsigned _BitInt(37) x)
return x >> c;
// CHECK: constant { i16, i16, [20 x i8] } { i16 2, i16 {{([[:xdigit:]]{2})}}, [20 x i8] c"'_BitInt(68)'\00D\00\00\00\00\00" }
}

int main(int argc, char **argv) {
// clang-format off
uint64_t result =
1ULL +
implicit_unsigned_integer_truncation() +
(uint32_t)array_bounds() +
float_cast_overflow() +
(uint64_t)implicit_signed_integer_truncation() +
negative_shift1(5) +
negative_shift2(5) +
negative_shift3(5) +
negative_shift5(5);
// clang-format on
printf("%u\n", (uint32_t)(result & 0xFFFFFFFF));
}
1 change: 1 addition & 0 deletions compiler-rt/test/ubsan/TestCases/Integer/bit-int-pass.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
// REQUIRES: x86_64-target-arch
// RUN: %clang -Wno-constant-conversion -Wno-array-bounds -Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative -Wno-int-to-pointer-cast -O0 -fsanitize=alignment,array-bounds,bool,float-cast-overflow,implicit-integer-sign-change,implicit-signed-integer-truncation,implicit-unsigned-integer-truncation,integer-divide-by-zero,nonnull-attribute,null,nullability-arg,nullability-assign,nullability-return,pointer-overflow,returns-nonnull-attribute,shift-base,shift-exponent,signed-integer-overflow,unreachable,unsigned-integer-overflow,unsigned-shift-base,vla-bound %s -o %t1 && %run %t1 2>&1 | FileCheck %s

#include <stdint.h>
Expand Down
4 changes: 4 additions & 0 deletions compiler-rt/test/ubsan/TestCases/Integer/bit-int.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
// REQUIRES: x86_64-target-arch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is about
https://lab.llvm.org/buildbot/#/builders/107/builds/1916

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will disabled for windows as well, please investigate after we fix bots?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Will look into this specific target.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the test does pass when there are 128-bit runtime routines available on Windows, which means the XFAIL breaks: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket/8739197731419270081/+/u/package_clang/stdout

I'll add REQUIRES: !windows for now instead.

// RUN: %clang -Wno-constant-conversion -Wno-array-bounds -Wno-division-by-zero -Wno-shift-negative-value -Wno-shift-count-negative -Wno-int-to-pointer-cast -O0 -fsanitize=array-bounds,float-cast-overflow,implicit-integer-sign-change,implicit-signed-integer-truncation,implicit-unsigned-integer-truncation,integer-divide-by-zero,pointer-overflow,shift-base,shift-exponent,signed-integer-overflow,unsigned-integer-overflow,unsigned-shift-base,vla-bound %s -o %t1 && %run %t1 2>&1 | FileCheck %s

// FIXME: make the test pass on windows.
// XFAIL: target={{.*windows-msvc.*}}

#include <stdint.h>
#include <stdio.h>

Expand Down
Loading