Skip to content

[mlir][ArmSME] Remove XFAILs #104758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024
Merged

[mlir][ArmSME] Remove XFAILs #104758

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions mlir/test/Integration/Dialect/Linalg/CPU/ArmSME/multi-tile-matmul-mixed-types.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,8 @@
/// tests a mixed i8 to i32 matmul and outer product fusion which fuses 16
/// outer products (four per tile) into four 4-way outer products.

/// NOTE: QEMU gives incorrect result for SME SMOPA 4-way outer product
/// instruction (version <= 8.2.0, latest version at time of writing), see:
/// https://gitlab.com/qemu-project/qemu/-/issues/2083
/// This test is expected to fail until a fixed version of QEMU can be used.

/// FIXME: Remove the 'XFAIL' below once a fixed QEMU version is available
/// (and installed on CI buildbot).
/// XFAIL: *
// NOTE: QEMU <= 8.2.0 gives incorrect result for SME SMOPA 4-way outer product
// instruction see: https://gitlab.com/qemu-project/qemu/-/issues/2083.

func.func @matmul_i8_to_i32(%A : tensor<?x?xi8>, %B : tensor<?x?xi8>, %C : tensor<?x?xi32>) {
%res = linalg.matmul ins(%A, %B: tensor<?x?xi8>, tensor<?x?xi8>)
Expand Down
10 changes: 2 additions & 8 deletions mlir/test/Integration/Dialect/Vector/CPU/ArmSME/outerproduct-i8i8i32.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,8 @@

// RUN: %{compile} | %{run} | FileCheck %s

// NOTE: QEMU gives incorrect result for SME SMOPA 4-way outer product
// instruction (version <= 8.2.0, latest version at time of writing), see:
// https://gitlab.com/qemu-project/qemu/-/issues/2083 This test is expected to
// fail (CHECK lines are correct) until a fixed version of QEMU can be used.

// FIXME: Remove the 'XFAIL' below once a fixed QEMU version is available
// (and installed on CI buildbot).
// XFAIL: *
// NOTE: QEMU <= 8.2.0 gives incorrect result for SME SMOPA 4-way outer product
// instruction see: https://gitlab.com/qemu-project/qemu/-/issues/2083.

// NOTE: there is no non-widening variant for these types and this test can't
// be lowered without the widening pass, therefore we can't check if the result
Expand Down
Loading