[Support] Remove unneeded __has_include fallback #104898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.5-bogner
|
@llvm/pr-subscribers-llvm-support Author: Fangrui Song (MaskRay) ChangesThis is a C++17 feature implemented in all supported compilers Full diff: https://github.com/llvm/llvm-project/pull/104898.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Support/Compiler.h b/llvm/include/llvm/Support/Compiler.h
index d8e3794babc744..9d8607f8dd9aca 100644
--- a/llvm/include/llvm/Support/Compiler.h
+++ b/llvm/include/llvm/Support/Compiler.h
@@ -39,10 +39,6 @@
# define __has_builtin(x) 0
#endif
-#ifndef __has_include
-# define __has_include(x) 0
-#endif
-
// Only use __has_cpp_attribute in C++ mode. GCC defines __has_cpp_attribute in
// C mode, but the :: in __has_cpp_attribute(scoped::attribute) is invalid.
#ifndef LLVM_HAS_CPP_ATTRIBUTE
|
boomanaiden154
approved these changes
Aug 20, 2024
s-barannikov
approved these changes
Aug 20, 2024
Endilll
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
Seems to be supported everywhere indeed.
https://godbolt.org/z/j7eMPco5G
MaskRay
deleted the
users/MaskRay/spr/support-remove-unneeded-__has_include-fallback
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a C++17 feature implemented in all supported compilers.