Skip to content

[mlir] NFC: add missing 'FloatType' to core Python stub file #105554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

christopherbate
Copy link
Contributor

@christopherbate christopherbate commented Aug 21, 2024

The stub class for FloatType is present in ir.pyi, but it is missing from the __all__ export list.

@llvmbot
Copy link
Member

llvmbot commented Aug 21, 2024

@llvm/pr-subscribers-mlir

Author: Christopher Bate (christopherbate)

Changes

The stub class for FloatType is present in ir.pyi, but it is missing from the __all__ export list.


Full diff: https://github.com/llvm/llvm-project/pull/105554.diff

1 Files Affected:

  • (modified) mlir/python/mlir/_mlir_libs/_mlir/ir.pyi (+1)
diff --git a/mlir/python/mlir/_mlir_libs/_mlir/ir.pyi b/mlir/python/mlir/_mlir_libs/_mlir/ir.pyi
index e3599d3c84ffed..4a2d0e977ccf26 100644
--- a/mlir/python/mlir/_mlir_libs/_mlir/ir.pyi
+++ b/mlir/python/mlir/_mlir_libs/_mlir/ir.pyi
@@ -129,6 +129,7 @@ __all__ = [
     "Float8E5M2Type",
     "FloatAttr",
     "FloatTF32Type",
+    "FloatType",
     "FunctionType",
     "IndexType",
     "InferShapedTypeOpInterface",

Copy link
Contributor

@makslevental makslevental left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@christopherbate christopherbate merged commit 92e00af into llvm:main Aug 26, 2024
11 checks passed
@christopherbate christopherbate deleted the mlir-fix-missing-type-in-pyi branch August 26, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mlir:python MLIR Python bindings mlir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants