Skip to content

[test-suite] Document the LLVM test-suite benchmark apps #105843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

sjoerdmeijer
Copy link
Collaborator

There is no documentation or description of the different apps in the LLVM benchmark test-suite and this is a first attempt to document this for the MultiSource apps.

Copy link
Contributor

@sparker-arm sparker-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good idea to me. Is it worth adding a column to state whether it's suitable for performance measurements? I guess my broader question would be whether that information is still encoded correctly in CMake too...

There is no documentation or description of the different apps in the
LLVM benchmark test-suite and this is a first attempt to document this.
@sjoerdmeijer
Copy link
Collaborator Author

sjoerdmeijer commented Aug 30, 2024

Seems like a good idea to me. Is it worth adding a column to state whether it's suitable for performance measurements? I guess my broader question would be whether that information is still encoded correctly in CMake too...

Thanks, good point.

I have checked that all apps are suitable for perf measurements. I.e., none of the top-level apps/directories are excluded, and only a few apps (benchmark suites) have sub-directories that are excluded when TEST_SUITE_BENCHMARKING_ONLY is not set, for example this is the pattern:

 ...
add_subdirectory(17-bintr)
add_subdirectory(18-imp)
if(NOT TEST_SUITE_BENCHMARKING_ONLY)
    add_subdirectory(15-trie)
endif()

I have removed these benchmark from the "remark" column if it was included and spelled out to be part of the benchmark suite, and added a sentence that should clarify that all apps are suitable for perf measurements.

Copy link
Contributor

@sparker-arm sparker-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, cheers. LGTM

@sjoerdmeijer sjoerdmeijer merged commit c4a5381 into llvm:main Aug 30, 2024
6 of 8 checks passed
@sjoerdmeijer sjoerdmeijer deleted the testsuite-benchmarks branch August 30, 2024 14:36
@fhahn
Copy link
Contributor

fhahn commented Sep 9, 2024

Thanks for putting this together!

@sjoerdmeijer
Copy link
Collaborator Author

Thanks for putting this together!

Cheers. I will follow up with the SingleSource apps, but wanted to test the water for MultiSource first, and it is a bit of work.

Just as some sort of heads up, I wanted to look at the exact contents of the test-suite first before proposing some changes to it and this is basically the result of that. I will work on a little proposal to add some new ones and changes some existing apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants