[SandboxIR] Implement FenceInst #105920
Merged
[SandboxIR] Implement FenceInst #105920
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch implements sandboxir::FenceInst mirroring llvm::FenceInst.
vporpo
requested review from
slackito,
echristo,
alinas,
tschuett,
aeubanks,
tmsri and
Sterling-Augustine
tmsri
approved these changes
Aug 26, 2024
| @@ -575,6 +575,33 @@ void Instruction::dumpOS(raw_ostream &OS) const { | |||
| } | |||
| #endif // NDEBUG | |||
|
|
|||
| FenceInst *FenceInst::create(AtomicOrdering Ordering, BBIterator WhereIt, | |||
| BasicBlock *WhereBB, Context &Ctx, | |||
There was a problem hiding this comment.
Why not use llvm::InsertPosition to define where to insert?
There was a problem hiding this comment.
We don't have an InsertPosition class yet. We will refactor all create() functions at some point to use that once it's available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements sandboxir::FenceInst mirroring llvm::FenceInst.