[mlir][Transforms][NFC] Dialect conversion: Remove redundant ReplaceBlockArgRewrite
#105963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ArgRewrite` There was a redundant `appendRewrite<ReplaceBlockArgRewrite>(block, origArg);` in `ConversionPatternRewriterImpl::applySignatureConversion` that had no effect.
matthias-springer
changed the title
ReplaceBlockArgRewriteReplaceBlockArgRewrite
| @@ -1296,7 +1296,6 @@ Block *ConversionPatternRewriterImpl::applySignatureConversion( | |||
| OpBuilder::InsertPoint(newBlock, newBlock->begin()), origArg.getLoc(), | |||
| /*inputs=*/replArgs, origArgType, converter); | |||
| mapping.map(origArg, argMat); | |||
| appendRewrite<ReplaceBlockArgRewrite>(block, origArg); | |||
There was a problem hiding this comment.
Note: Identical ReplaceBlockArgRewrite at line 1320.
|
@llvm/pr-subscribers-mlir-core @llvm/pr-subscribers-mlir Author: Matthias Springer (matthias-springer) ChangesThere was a redundant Full diff: https://github.com/llvm/llvm-project/pull/105963.diff 1 Files Affected:
diff --git a/mlir/lib/Transforms/Utils/DialectConversion.cpp b/mlir/lib/Transforms/Utils/DialectConversion.cpp
index 4058ed39621198..cc9c9495e5155c 100644
--- a/mlir/lib/Transforms/Utils/DialectConversion.cpp
+++ b/mlir/lib/Transforms/Utils/DialectConversion.cpp
@@ -1296,7 +1296,6 @@ Block *ConversionPatternRewriterImpl::applySignatureConversion(
OpBuilder::InsertPoint(newBlock, newBlock->begin()), origArg.getLoc(),
/*inputs=*/replArgs, origArgType, converter);
mapping.map(origArg, argMat);
- appendRewrite<ReplaceBlockArgRewrite>(block, origArg);
Type legalOutputType;
if (converter) {
|
zero9178
approved these changes
Aug 25, 2024
matthias-springer
deleted the
users/matthias-springer/redundant_replace_block_arg_rew
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a redundant
appendRewrite<ReplaceBlockArgRewrite>(block, origArg);inConversionPatternRewriterImpl::applySignatureConversionthat had no effect.