[test-release.sh] Fix sed encoding issues on macOS #105989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using bsd sed that ships with macOS on the object files for comparison, every command would error with ``` sed: RE error: illegal byte sequence ``` This was potentially fixed for an older version in 6c52b02 but even the commands in the example there still have this error. You can repro this with any binary: ``` $ sed s/a/b/ /bin/ls >/dev/null sed: RE error: illegal byte sequence ``` Where LC_CTYPE appears to no longer solve the issue: ``` $ LC_CTYPE=C sed s/a/b/ /bin/ls >/dev/null sed: RE error: illegal byte sequence ``` But this change with LC_ALL does: ``` $ LC_ALL=C sed s/a/b/ /bin/ls >/dev/null; echo $? 0 ``` It seems like the difference here is that if you have LC_ALL set to something else, LC_CTYPE does not override it. More info: https://stackoverflow.com/a/23584470/902968
keith
changed the title
tru
approved these changes
Aug 28, 2024
keith
deleted the
ks/test-release.sh-fix-sed-encoding-issues-on-macos
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using bsd sed that ships with macOS on the object files for comparison, every command would error with
This was potentially fixed for an older version in 6c52b02 but even the commands in the example there still have this error. You can repro this with any binary:
Where LC_CTYPE appears to no longer solve the issue:
But this change with LC_ALL does:
It seems like the difference here is that if you have LC_ALL set to something else, LC_CTYPE does not override it. More info: https://stackoverflow.com/a/23584470/902968