-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[test-release.sh] Fix python 3.12 compatibility #105993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test-release.sh] Fix python 3.12 compatibility #105993
Conversation
Virtual environments in python 3.12 no longer installs setuptools by default in order to push people towards newer syntax for installing packages. This new syntax is also compatible with python 3.8 which is the current lowest supported version mentioned in the docs. Docs: https://packaging.python.org/en/latest/discussions/setup-py-deprecated/#what-commands-should-be-used-instead Fixes: llvm#90197
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/4584 Here is the relevant piece of the build log for the reference
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/3170 Here is the relevant piece of the build log for the reference
|
Virtual environments in python 3.12 no longer installs setuptools by default in order to push people towards newer syntax for installing packages. This new syntax is also compatible with python 3.8 which is the current lowest supported version mentioned in the docs.
Docs: https://packaging.python.org/en/latest/discussions/setup-py-deprecated/#what-commands-should-be-used-instead
Fixes: #90197