Skip to content

[MLGO] Remove Python <3.8 from unsupported config #106132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

boomanaiden154
Copy link
Contributor

Now that Python 3.8 is the minimum version supported by LLVM, we don't need to explicitly check that the python version we are using is greater than 3.8 in the MLGO tests.

Now that Python 3.8 is the minimum version supported by LLVM, we don't
need to explicitly check that the python version we are using is greater
than 3.8 in the MLGO tests.
@llvmbot
Copy link
Member

llvmbot commented Aug 26, 2024

@llvm/pr-subscribers-mlgo

@llvm/pr-subscribers-llvm-transforms

Author: Aiden Grossman (boomanaiden154)

Changes

Now that Python 3.8 is the minimum version supported by LLVM, we don't need to explicitly check that the python version we are using is greater than 3.8 in the MLGO tests.


Full diff: https://github.com/llvm/llvm-project/pull/106132.diff

2 Files Affected:

  • (removed) llvm/test/CodeGen/MLRegAlloc/lit.local.cfg (-3)
  • (removed) llvm/test/Transforms/Inline/ML/lit.local.cfg (-3)
diff --git a/llvm/test/CodeGen/MLRegAlloc/lit.local.cfg b/llvm/test/CodeGen/MLRegAlloc/lit.local.cfg
deleted file mode 100644
index e8c7912650cb8e..00000000000000
--- a/llvm/test/CodeGen/MLRegAlloc/lit.local.cfg
+++ /dev/null
@@ -1,3 +0,0 @@
-import sys
-
-config.unsupported = sys.version_info.minor <= 8
diff --git a/llvm/test/Transforms/Inline/ML/lit.local.cfg b/llvm/test/Transforms/Inline/ML/lit.local.cfg
deleted file mode 100644
index e8c7912650cb8e..00000000000000
--- a/llvm/test/Transforms/Inline/ML/lit.local.cfg
+++ /dev/null
@@ -1,3 +0,0 @@
-import sys
-
-config.unsupported = sys.version_info.minor <= 8

@mtrofin
Copy link
Member

mtrofin commented Aug 26, 2024

Nice!

@mtrofin
Copy link
Member

mtrofin commented Aug 26, 2024

Can we revert e.g. d62cdfa (IIRC it was in order to support 3.7)?

@boomanaiden154
Copy link
Contributor Author

Can we revert e.g. d62cdfa (IIRC it was in order to support 3.7)?

Not entirely sure of the context of that patch. I'll look into it.

@boomanaiden154 boomanaiden154 merged commit a959d70 into llvm:main Aug 26, 2024
8 of 10 checks passed
@boomanaiden154 boomanaiden154 deleted the mlgo-drop-3-8-unsupported branch August 26, 2024 20:57
@dyung
Copy link
Collaborator

dyung commented Aug 26, 2024

@boomanaiden154 your change seems to be causing a test failure of `llvm/test/CodeGen/MLRegAlloc/interactive-mode.ll' on a bot.

https://lab.llvm.org/buildbot/#/builders/174/builds/3975

Can you take a look and revert if you need time to investigate?

@boomanaiden154
Copy link
Contributor Author

c3776c1

Looks like there might actually be some compatibility issues with Python 3.8 (the script marked 3.8 as unsupported and only picked up versions 3.9 and newer).

boomanaiden154 added a commit that referenced this pull request Aug 27, 2024
This reverts commit c3776c1.

This relands commit a959d70.

This was originally causing bot failures on Python version 3.8.
This relanding fixes that by adjusting the relevant type annotations
that are not supported in earlier versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants