-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[MLGO] Remove Python <3.8 from unsupported config #106132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MLGO] Remove Python <3.8 from unsupported config #106132
Conversation
Now that Python 3.8 is the minimum version supported by LLVM, we don't need to explicitly check that the python version we are using is greater than 3.8 in the MLGO tests.
@llvm/pr-subscribers-mlgo @llvm/pr-subscribers-llvm-transforms Author: Aiden Grossman (boomanaiden154) ChangesNow that Python 3.8 is the minimum version supported by LLVM, we don't need to explicitly check that the python version we are using is greater than 3.8 in the MLGO tests. Full diff: https://github.com/llvm/llvm-project/pull/106132.diff 2 Files Affected:
diff --git a/llvm/test/CodeGen/MLRegAlloc/lit.local.cfg b/llvm/test/CodeGen/MLRegAlloc/lit.local.cfg
deleted file mode 100644
index e8c7912650cb8e..00000000000000
--- a/llvm/test/CodeGen/MLRegAlloc/lit.local.cfg
+++ /dev/null
@@ -1,3 +0,0 @@
-import sys
-
-config.unsupported = sys.version_info.minor <= 8
diff --git a/llvm/test/Transforms/Inline/ML/lit.local.cfg b/llvm/test/Transforms/Inline/ML/lit.local.cfg
deleted file mode 100644
index e8c7912650cb8e..00000000000000
--- a/llvm/test/Transforms/Inline/ML/lit.local.cfg
+++ /dev/null
@@ -1,3 +0,0 @@
-import sys
-
-config.unsupported = sys.version_info.minor <= 8
|
Nice! |
Can we revert e.g. d62cdfa (IIRC it was in order to support 3.7)? |
Not entirely sure of the context of that patch. I'll look into it. |
@boomanaiden154 your change seems to be causing a test failure of `llvm/test/CodeGen/MLRegAlloc/interactive-mode.ll' on a bot. https://lab.llvm.org/buildbot/#/builders/174/builds/3975 Can you take a look and revert if you need time to investigate? |
This reverts commit a959d70. This was causing bot failures. https://lab.llvm.org/buildbot/#/builders/174/builds/3975
Looks like there might actually be some compatibility issues with Python 3.8 (the script marked 3.8 as unsupported and only picked up versions 3.9 and newer). |
Now that Python 3.8 is the minimum version supported by LLVM, we don't need to explicitly check that the python version we are using is greater than 3.8 in the MLGO tests.