Skip to content

[SPIRV] Fix build after change in transitive includes #106140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

bogner
Copy link
Contributor

@bogner bogner commented Aug 26, 2024

An unordered_set include was removed from a header in 04ebd19 "[MC][NFC] Statically allocate storage for decoded pseudo probes and function records (#102789)", but SPIRVEmitIntrinsics was getting the definition from that transitive include. Fix the build by including the header explicitly.

An unordered_set include was removed from a header in 04ebd19
"[MC][NFC] Statically allocate storage for decoded pseudo probes and
function records (llvm#102789)", but SPIRVEmitIntrinsics was getting the
definition from that transitive include. Fix the build by including
the header explicitly.
@llvmbot
Copy link
Member

llvmbot commented Aug 26, 2024

@llvm/pr-subscribers-backend-spir-v

Author: Justin Bogner (bogner)

Changes

An unordered_set include was removed from a header in 04ebd19 "[MC][NFC] Statically allocate storage for decoded pseudo probes and function records (#102789)", but SPIRVEmitIntrinsics was getting the definition from that transitive include. Fix the build by including the header explicitly.


Full diff: https://github.com/llvm/llvm-project/pull/106140.diff

1 Files Affected:

  • (modified) llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp (+1)
diff --git a/llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp b/llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp
index d9864ab50ecfe3..4175f766ac69ad 100644
--- a/llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVEmitIntrinsics.cpp
@@ -24,6 +24,7 @@
 #include "llvm/IR/TypedPointerType.h"
 
 #include <queue>
+#include <unordered_set>
 
 // This pass performs the following transformation on LLVM IR level required
 // for the following translation to SPIR-V:

Copy link
Contributor

@dmpots dmpots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pow2clk pow2clk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Easy fix!

@bogner bogner merged commit 70ffcfe into llvm:main Aug 26, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants