[mlir][Linalg] Fix match convolution message #106197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the message part of bugfix commit `2ef3dcf`.
yifeizh2
requested review from
dcaballe,
nicolasvasilache and
rengolin
as code owners
yifeizh2
requested review from
kazutakahirata
and removed request for
rengolin,
nicolasvasilache and
dcaballe
|
@llvm/pr-subscribers-mlir Author: None (yifeizh2) ChangesFix the message part of bugfix commit Full diff: https://github.com/llvm/llvm-project/pull/106197.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp b/mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp
index d5c21fb5d845e9..0c48a5aeb26a26 100644
--- a/mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp
+++ b/mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp
@@ -919,7 +919,7 @@ mlir::linalg::detail::getMatchConvolutionMessage(MatchConvolutionResult res) {
case MatchConvolutionResult::NonOutputDimNotReduction:
return "expected all iterators not used to access outputs to be reduction";
case MatchConvolutionResult::EmptyConvolvedDims:
- return "FIXME";
+ return "expected convolved dim to be non-empty";
case MatchConvolutionResult::Success:
return "";
}
|
|
@llvm/pr-subscribers-mlir-linalg Author: None (yifeizh2) ChangesFix the message part of bugfix commit Full diff: https://github.com/llvm/llvm-project/pull/106197.diff 1 Files Affected:
diff --git a/mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp b/mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp
index d5c21fb5d845e9..0c48a5aeb26a26 100644
--- a/mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp
+++ b/mlir/lib/Dialect/Linalg/IR/LinalgInterfaces.cpp
@@ -919,7 +919,7 @@ mlir::linalg::detail::getMatchConvolutionMessage(MatchConvolutionResult res) {
case MatchConvolutionResult::NonOutputDimNotReduction:
return "expected all iterators not used to access outputs to be reduction";
case MatchConvolutionResult::EmptyConvolvedDims:
- return "FIXME";
+ return "expected convolved dim to be non-empty";
case MatchConvolutionResult::Success:
return "";
}
|
rengolin
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the message part of bugfix commit
2ef3dcf.