-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[llvm-lit] Add precommit test to verify current behavior of glob expansion in lit's internal shell #106325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[llvm-lit] Add precommit test to verify current behavior of glob expansion in lit's internal shell #106325
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
36c5ece
[llvm-lit] Add shtest-glob.py test to verify glob pattern handling
Harini0924 9e193b2
Added the lit.cfg file
Harini0924 5ab8232
[llvm-lit] Rename and update test files for glob pattern handling
Harini0924 4e0657c
Fixed the trailing whitespace
Harini0924 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
## This is the first example file used for testing glob pattern matching. | ||
This is the first example file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
## This is the second example file used for testing glob pattern matching. | ||
This is the second example file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
## Tests glob pattern expansion by listing matching files. | ||
# RUN: echo %S/example_file*.input |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
## Tests glob pattern handling in the mkdir command. | ||
# RUN: not mkdir %S/example_file*.input |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import lit.formats | ||
|
||
config.name = "shtest-glob" | ||
config.suffixes = [".txt"] | ||
config.test_format = lit.formats.ShTest() | ||
config.test_source_root = None | ||
config.test_exec_root = None | ||
config.substitutions.append(("%{python}", '"%s"' % (sys.executable))) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
## Tests glob pattern handling in echo command. | ||
|
||
# RUN: not %{lit} -a -v %{inputs}/shtest-glob \ | ||
# RUN: | FileCheck -dump-input=fail -match-full-lines %s | ||
# | ||
# END. | ||
|
||
# CHECK: UNRESOLVED: shtest-glob :: glob-echo.txt ({{[^)]*}}) | ||
# CHECK: TypeError: string argument expected, got 'GlobItem' | ||
|
||
# CHECK: FAIL: shtest-glob :: glob-mkdir.txt ({{[^)]*}} | ||
# CHECK: # error: command failed with exit status: 1 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was surprised there is no more specific error here but it looks like the builtin mkdir does not print any output right now. Turns out it doesn't handle EEXISTS the same way as the real mkdir command. I can submit a patch for this once this commit lands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A patch to address that would be great, and I’m looking forward to seeing it once this commit lands.