Skip to content

[AMDGPU] Use range-based for loops (NFC) #106328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2024
+5 −13
Merged

[AMDGPU] Use range-based for loops (NFC) #106328

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d156224
[AMDGPU] Use range-based for loops (NFC)
kazutakahirata Aug 27, 2024
4d895f9
Use isPhysical instead of isVirtual.
kazutakahirata Aug 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions llvm/lib/Target/AMDGPU/R600InstrInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,12 +75,9 @@ void R600InstrInfo::copyPhysReg(MachineBasicBlock &MBB,
/// \returns true if \p MBBI can be moved into a new basic.
bool R600InstrInfo::isLegalToSplitMBBAt(MachineBasicBlock &MBB,
MachineBasicBlock::iterator MBBI) const {
for (MachineInstr::const_mop_iterator I = MBBI->operands_begin(),
E = MBBI->operands_end(); I != E; ++I) {
if (I->isReg() && !I->getReg().isVirtual() && I->isUse() &&
RI.isPhysRegLiveAcrossClauses(I->getReg()))
for (const MachineOperand &MO : MBBI->all_uses())
if (!MO.getReg().isVirtual() && RI.isPhysRegLiveAcrossClauses(MO.getReg()))
return false;
}
return true;
}

Expand Down Expand Up @@ -219,15 +216,10 @@ bool R600InstrInfo::readsLDSSrcReg(const MachineInstr &MI) const {
if (!isALUInstr(MI.getOpcode())) {
return false;
}
for (MachineInstr::const_mop_iterator I = MI.operands_begin(),
E = MI.operands_end();
I != E; ++I) {
if (!I->isReg() || !I->isUse() || I->getReg().isVirtual())
continue;

if (R600::R600_LDS_SRC_REGRegClass.contains(I->getReg()))
for (const MachineOperand &MO : MI.all_uses())
if (MO.getReg().isPhysical() &&
R600::R600_LDS_SRC_REGRegClass.contains(MO.getReg()))
return true;
}
return false;
}

Expand Down
Loading