Skip to content

[libc++] Switch to the current XCode beta on macOS builders #106363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

philnik777
Copy link
Contributor

@philnik777 philnik777 commented Aug 28, 2024

This unblocks a ton of work including #76756 as it updates to a newer version of AppleClang.

@philnik777 philnik777 marked this pull request as ready for review August 28, 2024 12:57
@llvmbot llvmbot added libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. github:workflow labels Aug 28, 2024
@llvmbot
Copy link
Member

llvmbot commented Aug 28, 2024

@llvm/pr-subscribers-github-workflow

@llvm/pr-subscribers-libcxx

Author: Nikolas Klauser (philnik777)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/106363.diff

1 Files Affected:

  • (modified) .github/workflows/libcxx-build-and-test.yaml (+1-1)
diff --git a/.github/workflows/libcxx-build-and-test.yaml b/.github/workflows/libcxx-build-and-test.yaml
index 3af1b1abe2d4bb..1a26a699db8e01 100644
--- a/.github/workflows/libcxx-build-and-test.yaml
+++ b/.github/workflows/libcxx-build-and-test.yaml
@@ -208,7 +208,7 @@ jobs:
       - uses: actions/checkout@v4
       - uses: maxim-lobanov/setup-xcode@v1
         with:
-          xcode-version: 'latest-stable'
+          xcode-version: 'latest'
       - uses: seanmiddleditch/gha-setup-ninja@master
       - name: Build and test
         run: |

@ldionne ldionne changed the title [libc++] Switch to the current XCode beta to unblock #76756 [libc++] Switch to the current XCode beta on macOS builders Aug 28, 2024
Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should go back to latest-stable once the beta is finalized.

Note that I am fine with moving to the beta because so much work is blocked on this update.

@ldionne ldionne merged commit ec9f36a into llvm:main Aug 28, 2024
63 checks passed
@philnik777 philnik777 deleted the update_xcode branch August 28, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github:workflow libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants