Fix CLANG_BOOTSTRAP_TARGETS in Release.cmake #106407
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Before this patch you could not build the
stage2-LLVM
for example because you first had to manually add it toCLANG_BOOTSTRAP_TARGETS
in theRelease.cmake
and also add it toLLVM_RELEASE_FINAL_STAGE_TARGETS
in the cmake configure run. Now you can just use-DLLVM_RELEASE_FINAL_STAGE_TARGETS="LLVM;clang"
on the cmake CLI and be able to build the targetsstage2-LLVM
andstage2-clang
without further changes to the cache file.Solution
Take all
LLVM_RELEASE_FINAL_STAGE_TARGETS
elements and append them prefixed withstage2-
toCLANG_BOOTSTRAP_TARGETS
. Afterwards all duplicates are removed.