DAG: Change round-mode operand type to i32 for FPTRUNC_ROUND #106424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need this immediate type to be consistent.
|
@llvm/pr-subscribers-llvm-selectiondag Author: Changpeng Fang (changpeng) ChangesWe need this immediate type to be consistent. This is the pre-commit for #105761 Full diff: https://github.com/llvm/llvm-project/pull/106424.diff 1 Files Affected:
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
index 60dcb118542785..851c646b1cb333 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
@@ -6957,8 +6957,7 @@ void SelectionDAGBuilder::visitIntrinsicCall(const CallInst &I,
SDValue Result;
Result = DAG.getNode(
ISD::FPTRUNC_ROUND, sdl, VT, getValue(I.getArgOperand(0)),
- DAG.getTargetConstant((int)*RoundMode, sdl,
- TLI.getPointerTy(DAG.getDataLayout())));
+ DAG.getTargetConstant((int)*RoundMode, sdl, MVT::i32));
setValue(&I, Result);
return;
|
You can test this locally with the following command:git-clang-format --diff 25d976b45cb5b3d222d3a9cd94caa8a54031bbb7 d2acd858ae79f5256a44ae1feca328118e4b220b --extensions cpp -- llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cppView the diff from clang-format here.diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
index 851c646b1c..4a2bd89ff9 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
@@ -6955,9 +6955,9 @@ void SelectionDAGBuilder::visitIntrinsicCall(const CallInst &I,
SelectionDAG::FlagInserter FlagsInserter(DAG, Flags);
SDValue Result;
- Result = DAG.getNode(
- ISD::FPTRUNC_ROUND, sdl, VT, getValue(I.getArgOperand(0)),
- DAG.getTargetConstant((int)*RoundMode, sdl, MVT::i32));
+ Result =
+ DAG.getNode(ISD::FPTRUNC_ROUND, sdl, VT, getValue(I.getArgOperand(0)),
+ DAG.getTargetConstant((int)*RoundMode, sdl, MVT::i32));
setValue(&I, Result);
return;
|
arsenm
reviewed
Aug 28, 2024
changpeng
changed the title
|
arsenm
changed the title
arsenm
approved these changes
Aug 28, 2024
qiaojbao
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Sep 30, 2024
…24ccc2ecf Local branch amd-gfx 20624cc Merged main:73e0aa58666f235bef091735a5f189882acc1148 into amd-gfx:e64f6fcf29c6 Remote branch main 41b5507 DAG: Change round-mode operand type to i32 for FPTRUNC_ROUND (llvm#106424)
searlmc1
pushed a commit
to ROCm/llvm-project
that referenced
this pull request
Feb 3, 2025
…6424) We need this immediate type to be consistent. This is the pre-commit for llvm#105761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need this immediate type to be consistent. This is the pre-commit for #105761