Skip to content

AMDGPU: Rename fail.llvm.fptrunc.round.ll to llvm.fptrunc.round.err.ll #106452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

changpeng
Copy link
Contributor

Also correct the suffix of the intrinsic

@llvmbot
Copy link
Member

llvmbot commented Aug 28, 2024

@llvm/pr-subscribers-backend-amdgpu

Author: Changpeng Fang (changpeng)

Changes

Also correct the suffix of the intrinsic


Full diff: https://github.com/llvm/llvm-project/pull/106452.diff

1 Files Affected:

  • (renamed) llvm/test/CodeGen/AMDGPU/llvm.fptrunc.round.err.ll (+2-2)
diff --git a/llvm/test/CodeGen/AMDGPU/fail.llvm.fptrunc.round.ll b/llvm/test/CodeGen/AMDGPU/llvm.fptrunc.round.err.ll
similarity index 77%
rename from llvm/test/CodeGen/AMDGPU/fail.llvm.fptrunc.round.ll
rename to llvm/test/CodeGen/AMDGPU/llvm.fptrunc.round.err.ll
index 9fa3eb22a554a8..4bcd0cf5e6a0e5 100644
--- a/llvm/test/CodeGen/AMDGPU/fail.llvm.fptrunc.round.ll
+++ b/llvm/test/CodeGen/AMDGPU/llvm.fptrunc.round.err.ll
@@ -4,9 +4,9 @@
 define amdgpu_gs void @test_fptrunc_round_f64(double %a, ptr addrspace(1) %out) {
 ; SDAG-FAIL: LLVM ERROR: Cannot select
 ; GISEL-FAIL: unable to legalize instruction
-  %res = call half @llvm.fptrunc.round.f64(double %a, metadata !"round.upward")
+  %res = call half @llvm.fptrunc.round.f16.f64(double %a, metadata !"round.upward")
   store half %res, ptr addrspace(1) %out, align 4
   ret void
 }
 
-declare half @llvm.fptrunc.round.f64(double, metadata)
+declare half @llvm.fptrunc.round.f16.f64(double, metadata)

@changpeng changpeng merged commit 53d95f3 into llvm:main Aug 28, 2024
6 of 8 checks passed
@changpeng changpeng deleted the test branch August 28, 2024 20:52
searlmc1 pushed a commit to ROCm/llvm-project that referenced this pull request Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants