[clang][RISCV] Fix typo of vector crypto in SemaRISCV.cpp. NFC #106485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-backend-risc-v @llvm/pr-subscribers-clang Author: Brandon Wu (4vtomat) ChangesFull diff: https://github.com/llvm/llvm-project/pull/106485.diff 1 Files Affected:
diff --git a/clang/lib/Sema/SemaRISCV.cpp b/clang/lib/Sema/SemaRISCV.cpp
index abf8e4ac2f3e8a..56d6f12fbc6e4a 100644
--- a/clang/lib/Sema/SemaRISCV.cpp
+++ b/clang/lib/Sema/SemaRISCV.cpp
@@ -733,7 +733,7 @@ bool SemaRISCV::CheckBuiltinFunctionCall(const TargetInfo &TI,
if (ElemSize == 64 && !TI.hasFeature("zvknhb"))
return Diag(TheCall->getBeginLoc(),
diag::err_riscv_builtin_requires_extension)
- << /* IsExtension */ true << TheCall->getSourceRange() << "zvknb";
+ << /* IsExtension */ true << TheCall->getSourceRange() << "zvknhb";
return CheckInvalidVLENandLMUL(TI, TheCall, SemaRef, Op1Type,
ElemSize * 4) ||
|
topperc
reviewed
Aug 29, 2024
| @@ -733,7 +733,7 @@ bool SemaRISCV::CheckBuiltinFunctionCall(const TargetInfo &TI, | |||
| if (ElemSize == 64 && !TI.hasFeature("zvknhb")) | |||
| return Diag(TheCall->getBeginLoc(), | |||
| diag::err_riscv_builtin_requires_extension) | |||
| << /* IsExtension */ true << TheCall->getSourceRange() << "zvknb"; | |||
| << /* IsExtension */ true << TheCall->getSourceRange() << "zvknhb"; | |||
There was a problem hiding this comment.
Can we have a test for this?
There was a problem hiding this comment.
I think we can't, since the RequiredFeatures in riscv_vector.td already blocks the intrinsic generation, I guess we don't even need this check, do we?
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/51/builds/3375 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.