[AMDGPU][NewPM] Have consistent property changes in GCNDPPCombine #106520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-amdgpu Author: Akshat Oke (Akshat-Oke) ChangesFull diff: https://github.com/llvm/llvm-project/pull/106520.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/GCNDPPCombine.cpp b/llvm/lib/Target/AMDGPU/GCNDPPCombine.cpp
index 3e1a79062ff0cc..833cd6dfa4ba2e 100644
--- a/llvm/lib/Target/AMDGPU/GCNDPPCombine.cpp
+++ b/llvm/lib/Target/AMDGPU/GCNDPPCombine.cpp
@@ -795,11 +795,11 @@ bool GCNDPPCombine::run(MachineFunction &MF) {
PreservedAnalyses GCNDPPCombinePass::run(MachineFunction &MF,
MachineFunctionAnalysisManager &) {
+ MFPropsModifier _(*this, MF);
+
if (MF.getFunction().hasOptNone())
return PreservedAnalyses::all();
- MFPropsModifier _(*this, MF);
-
bool Changed = GCNDPPCombine().run(MF);
if (!Changed)
return PreservedAnalyses::all();
|
cdevadas
approved these changes
Sep 3, 2024
qiaojbao
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Sep 30, 2024
…e7da32635 Local branch amd-gfx 3cfe7da Merged main:b6a4ab5a12c9ced0642769e4b2d8f77859541ba8 into amd-gfx:6ab9923b43c0 Remote branch main 8e5b43c [AMDGPU][NewPM] Have consistent property changes in GCNDPPCombine (llvm#106520)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.