Skip to content

libcxx: [NFC] relax error expectation for clang diagnostics #106591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mizvekov
Copy link
Contributor

This is a split-off from #96023, where this change has already been reviewed by libcxx maintainers.

This will prevent that PR from triggering libcxx-ci from now on.

This is a split-off from llvm#96023, where this change has alrewady been
reviewed by libcxx maintainers.

This will prevent that PR from triggering libcxx-ci from now on.
@mizvekov mizvekov self-assigned this Aug 29, 2024
@mizvekov mizvekov requested a review from a team as a code owner August 29, 2024 17:32
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Aug 29, 2024
@llvmbot
Copy link
Member

llvmbot commented Aug 29, 2024

@llvm/pr-subscribers-libcxx

Author: Matheus Izvekov (mizvekov)

Changes

This is a split-off from #96023, where this change has already been reviewed by libcxx maintainers.

This will prevent that PR from triggering libcxx-ci from now on.


Full diff: https://github.com/llvm/llvm-project/pull/106591.diff

1 Files Affected:

  • (modified) libcxx/test/libcxx/type_traits/is_specialization.verify.cpp (+1-1)
diff --git a/libcxx/test/libcxx/type_traits/is_specialization.verify.cpp b/libcxx/test/libcxx/type_traits/is_specialization.verify.cpp
index a798647d56ee1c..3593c2e095db91 100644
--- a/libcxx/test/libcxx/type_traits/is_specialization.verify.cpp
+++ b/libcxx/test/libcxx/type_traits/is_specialization.verify.cpp
@@ -17,5 +17,5 @@
 #include <array>
 #include <utility>
 
-// expected-error@+1 {{template template argument has different template parameters than its corresponding template template parameter}}
+// expected-error-re@*:* {{{{could not match _Size against 'type-parameter-0-0'|different template parameters}}}}
 static_assert(!std::__is_specialization_v<std::pair<int, std::size_t>, std::array>);

@mizvekov mizvekov merged commit 67ffd14 into llvm:main Aug 29, 2024
11 of 13 checks passed
@mizvekov mizvekov deleted the users/mizvekov/libcxx-relax-ttp-verify-matches branch August 29, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants