Revert "[llvm-lit] Add precommit test to verify current behavior of glob expansion in lit's internal shell" #106763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lob expa…" This reverts commit 9764cf8.
|
@llvm/pr-subscribers-testing-tools Author: None (Harini0924) ChangesReverts llvm/llvm-project#106325 Full diff: https://github.com/llvm/llvm-project/pull/106763.diff 6 Files Affected:
diff --git a/llvm/utils/lit/tests/Inputs/shtest-glob/example_file1.input b/llvm/utils/lit/tests/Inputs/shtest-glob/example_file1.input
deleted file mode 100644
index 0987c9081ca1f3..00000000000000
--- a/llvm/utils/lit/tests/Inputs/shtest-glob/example_file1.input
+++ /dev/null
@@ -1,2 +0,0 @@
-## This is the first example file used for testing glob pattern matching.
-This is the first example file.
diff --git a/llvm/utils/lit/tests/Inputs/shtest-glob/example_file2.input b/llvm/utils/lit/tests/Inputs/shtest-glob/example_file2.input
deleted file mode 100644
index f1a843f308262e..00000000000000
--- a/llvm/utils/lit/tests/Inputs/shtest-glob/example_file2.input
+++ /dev/null
@@ -1,2 +0,0 @@
-## This is the second example file used for testing glob pattern matching.
-This is the second example file.
diff --git a/llvm/utils/lit/tests/Inputs/shtest-glob/glob-echo.txt b/llvm/utils/lit/tests/Inputs/shtest-glob/glob-echo.txt
deleted file mode 100644
index b69f5e74fd7281..00000000000000
--- a/llvm/utils/lit/tests/Inputs/shtest-glob/glob-echo.txt
+++ /dev/null
@@ -1,2 +0,0 @@
-## Tests glob pattern expansion by listing matching files.
-# RUN: echo %S/example_file*.input
diff --git a/llvm/utils/lit/tests/Inputs/shtest-glob/glob-mkdir.txt b/llvm/utils/lit/tests/Inputs/shtest-glob/glob-mkdir.txt
deleted file mode 100644
index d1329f5dbfaaed..00000000000000
--- a/llvm/utils/lit/tests/Inputs/shtest-glob/glob-mkdir.txt
+++ /dev/null
@@ -1,2 +0,0 @@
-## Tests glob pattern handling in the mkdir command.
-# RUN: not mkdir %S/example_file*.input
diff --git a/llvm/utils/lit/tests/Inputs/shtest-glob/lit.cfg b/llvm/utils/lit/tests/Inputs/shtest-glob/lit.cfg
deleted file mode 100644
index 4e5f4cac4c4653..00000000000000
--- a/llvm/utils/lit/tests/Inputs/shtest-glob/lit.cfg
+++ /dev/null
@@ -1,8 +0,0 @@
-import lit.formats
-
-config.name = "shtest-glob"
-config.suffixes = [".txt"]
-config.test_format = lit.formats.ShTest()
-config.test_source_root = None
-config.test_exec_root = None
-config.substitutions.append(("%{python}", '"%s"' % (sys.executable)))
diff --git a/llvm/utils/lit/tests/shtest-glob.py b/llvm/utils/lit/tests/shtest-glob.py
deleted file mode 100644
index 551331cb38e259..00000000000000
--- a/llvm/utils/lit/tests/shtest-glob.py
+++ /dev/null
@@ -1,12 +0,0 @@
-## Tests glob pattern handling in echo command.
-
-# RUN: not %{lit} -a -v %{inputs}/shtest-glob \
-# RUN: | FileCheck -dump-input=fail -match-full-lines %s
-#
-# END.
-
-# CHECK: UNRESOLVED: shtest-glob :: glob-echo.txt ({{[^)]*}})
-# CHECK: TypeError: string argument expected, got 'GlobItem'
-
-# CHECK: FAIL: shtest-glob :: glob-mkdir.txt ({{[^)]*}}
-# CHECK: # error: command failed with exit status: 1
|
fmayer
approved these changes
Aug 30, 2024
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/5147 Here is the relevant piece of the build log for the reference |
looks like a timeout, very unlikely related |
Harini0924
added a commit
to Harini0924/llvm-project
that referenced
this pull request
Sep 3, 2024
…glob expansion in lit's internal shell" (llvm#106763) This reverts commit 5af4ba2.
Harini0924
added a commit
that referenced
this pull request
Sep 5, 2024
…glob expansion in lit's internal shell" (#106763) (#107169) This reverts commit 5af4ba2. The previous patch was missing the closing parenthesis `)` in the `CHECK` statement in the `llvm/utils/lit/tests/shtest-glob.py` file: `# CHECK: FAIL: shtest-glob :: glob-mkdir.txt ({{[^)]*}}` This issue broke some build bots. This patch corrects the `CHECK` statement by adding the closing parenthesis: `# CHECK: FAIL: shtest-glob :: glob-mkdir.txt ({{[^)]*}})`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #106325
Broke some Buildbots.