[Offload] Fix disabling of cuda target on unsupported platforms #106835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The target name and the message are wrong -- both should say "cuda" for the filtering to work. Fixes commit 300e5b9 (llvm#93186).
|
@llvm/pr-subscribers-offload Author: WÁNG Xuěruì (xen0n) ChangesThe target name and the message are wrong -- both should say "cuda" for the filtering to work. Fixes commit 300e5b9 (#93186). Full diff: https://github.com/llvm/llvm-project/pull/106835.diff 1 Files Affected:
diff --git a/offload/CMakeLists.txt b/offload/CMakeLists.txt
index 4cd97a6a5ff63d..d91b5fa1959295 100644
--- a/offload/CMakeLists.txt
+++ b/offload/CMakeLists.txt
@@ -159,8 +159,8 @@ if(NOT (CMAKE_SYSTEM_PROCESSOR MATCHES "(x86_64)|(ppc64le)|(aarch64)$"
"Linux x86_64, ppc64le, or aarch64 hosts")
list(REMOVE_ITEM LIBOMPTARGET_PLUGINS_TO_BUILD "amdgpu")
endif()
- if("nvptx" IN_LIST LIBOMPTARGET_PLUGINS_TO_BUILD)
- message(STATUS "Not building CUDA plugin: only support AMDGPU in "
+ if("cuda" IN_LIST LIBOMPTARGET_PLUGINS_TO_BUILD)
+ message(STATUS "Not building CUDA plugin: only support CUDA in "
"Linux x86_64, ppc64le, or aarch64 hosts")
list(REMOVE_ITEM LIBOMPTARGET_PLUGINS_TO_BUILD "cuda")
endif()
|
jhuber6
approved these changes
Aug 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The target name and the message are wrong -- both should say "cuda" for the filtering to work.
Fixes commit 300e5b9 (#93186).