-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[AArch64][GlobalISel] Implement selectVaStartAAPCS #106979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
350019e
[AArch64][GlobalISel] Implement selectVaStartAAPCS
Him188 e121c29
Use STI from AArch64InstructionSelector
Him188 0910b49
Use commonAlignment
Him188 6517904
Fix alignment
Him188 9e3739c
Remove unnecessary tests
Him188 aa139b5
Move attributes to end of the file
Him188 bdfc020
Simplify MIR case
Him188 6c73e9f
Simplify MIR case
Him188 57c56d5
Merge branch 'llvm:main' into tguan/gisel-va
madhur13490 7c5bc2c
Let PointerInfo take care of alignment
madhur13490 785d26e
Fix formatting
madhur13490 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py | ||
# RUN: llc -O0 -mtriple=aarch64-unknown-linux -run-pass=instruction-select -verify-machineinstrs %s -o - | FileCheck %s -check-prefixes=CHECK | ||
|
||
--- | | ||
target datalayout = "e-m:e-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128-Fn32" | ||
target triple = "aarch64-unknown-linux" | ||
|
||
%struct.__va_list = type { ptr, ptr, ptr, i32, i32 } | ||
|
||
define i32 @va_start(ptr %a, ...) { | ||
entry: | ||
%ap = alloca %struct.__va_list, align 8 | ||
call void @llvm.lifetime.start.p0(i64 32, ptr %ap) | ||
call void @llvm.va_start.p0(ptr %ap) | ||
%vr_offs_p = getelementptr inbounds i8, ptr %ap, i64 28 | ||
%vr_offs = load i32, ptr %vr_offs_p, align 4 | ||
ret i32 %vr_offs | ||
} | ||
... | ||
--- | ||
name: va_start | ||
alignment: 16 | ||
legalized: true | ||
regBankSelected: true | ||
tracksRegLiveness: true | ||
fixedStack: | ||
- { id: 0, size: 4, alignment: 16 } | ||
stack: | ||
- { id: 0, size: 56, alignment: 8 } | ||
- { id: 1, size: 128, alignment: 16 } | ||
- { id: 2, name: ap, size: 32, alignment: 8 } | ||
body: | | ||
bb.0.entry: | ||
; CHECK-LABEL: name: va_start | ||
; CHECK: LIFETIME_START %stack.2.ap | ||
; CHECK-NEXT: [[ADDXri:%[0-9]+]]:gpr64sp = ADDXri %stack.2.ap, 0, 0 | ||
; CHECK-NEXT: [[ADDXri1:%[0-9]+]]:gpr64common = ADDXri %stack.0, 0, 0 | ||
; CHECK-NEXT: STRXui [[ADDXri1]], [[ADDXri]], 0 :: (store (s64) into %ir.ap) | ||
; CHECK-NEXT: [[ADDXri2:%[0-9]+]]:gpr64common = ADDXri %stack.0, 0, 0 | ||
; CHECK-NEXT: STRXui [[ADDXri2]], [[ADDXri]], 1 :: (store (s64) into %ir.ap + 8) | ||
; CHECK-NEXT: [[ADDXri3:%[0-9]+]]:gpr64common = ADDXri %stack.0, 0, 0 | ||
; CHECK-NEXT: STRXui [[ADDXri3]], [[ADDXri]], 2 :: (store (s64) into %ir.ap + 16) | ||
; CHECK-NEXT: [[MOVi32imm:%[0-9]+]]:gpr32 = MOVi32imm 0 | ||
; CHECK-NEXT: STRWui [[MOVi32imm]], [[ADDXri]], 6 :: (store (s32) into %ir.ap + 24, align 8) | ||
; CHECK-NEXT: [[MOVi32imm1:%[0-9]+]]:gpr32 = MOVi32imm 0 | ||
; CHECK-NEXT: STRWui [[MOVi32imm1]], [[ADDXri]], 7 :: (store (s32) into %ir.ap + 28, basealign 8) | ||
; CHECK-NEXT: [[LDRWui:%[0-9]+]]:gpr32 = LDRWui %stack.2.ap, 7 :: (dereferenceable load (s32) from %ir.vr_offs_p) | ||
; CHECK-NEXT: $w0 = COPY [[LDRWui]] | ||
LIFETIME_START %stack.2.ap | ||
%0:gpr(p0) = G_FRAME_INDEX %stack.2.ap | ||
G_VASTART %0(p0) :: (store (s256) into %ir.ap, align 8) | ||
%1:gpr(s64) = G_CONSTANT i64 28 | ||
%2:gpr(p0) = G_PTR_ADD %0, %1(s64) | ||
%3:gpr(s32) = G_LOAD %2(p0) :: (dereferenceable load (s32) from %ir.vr_offs_p) | ||
$w0 = COPY %3(s32) | ||
... |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't need IR section, and there's too much going on here