Skip to content

[clang-format] Handle spaces in file paths in git-clang-format.bat #107041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

owenca
Copy link
Contributor

@owenca owenca commented Sep 3, 2024

This patch is provided by @jeliebig.

Fixes #107017.

@llvmbot
Copy link
Member

llvmbot commented Sep 3, 2024

@llvm/pr-subscribers-clang-format

Author: Owen Pan (owenca)

Changes

This patch is provided by @jeliebig.

Fixes #107017.


Full diff: https://github.com/llvm/llvm-project/pull/107041.diff

1 Files Affected:

  • (modified) clang/tools/clang-format/git-clang-format.bat (+1-1)
diff --git a/clang/tools/clang-format/git-clang-format.bat b/clang/tools/clang-format/git-clang-format.bat
index 9965cd4312fe39..19c82d8a04132b 100644
--- a/clang/tools/clang-format/git-clang-format.bat
+++ b/clang/tools/clang-format/git-clang-format.bat
@@ -1 +1 @@
-py -3 %~pn0 %*
+py -3 "%~pn0" %*

Copy link

@jeliebig jeliebig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@owenca owenca merged commit 12c0823 into llvm:main Sep 4, 2024
10 checks passed
@owenca owenca deleted the 107017 branch September 4, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v18.1.8] clang-format: git integration doesn't work on Windows if the install path contains spaces
5 participants