Skip to content

[Analysis] Update getPromotionCandidatesForInstruction description (NFC) #107277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

teresajohnson
Copy link
Contributor

Updates the description for getPromotionCandidatesForInstruction to
reflect the cleanup done in #95624.

Updates the description for getPromotionCandidatesForInstruction to
reflect the cleanup done in llvm#95624.
@llvmbot llvmbot added the llvm:analysis Includes value tracking, cost tables and constant folding label Sep 4, 2024
@llvmbot
Copy link
Member

llvmbot commented Sep 4, 2024

@llvm/pr-subscribers-llvm-analysis

Author: Teresa Johnson (teresajohnson)

Changes

Updates the description for getPromotionCandidatesForInstruction to
reflect the cleanup done in #95624.


Full diff: https://github.com/llvm/llvm-project/pull/107277.diff

1 Files Affected:

  • (modified) llvm/include/llvm/Analysis/IndirectCallPromotionAnalysis.h (+2-3)
diff --git a/llvm/include/llvm/Analysis/IndirectCallPromotionAnalysis.h b/llvm/include/llvm/Analysis/IndirectCallPromotionAnalysis.h
index b9cf048a710435..b6bdfb1275c927 100644
--- a/llvm/include/llvm/Analysis/IndirectCallPromotionAnalysis.h
+++ b/llvm/include/llvm/Analysis/IndirectCallPromotionAnalysis.h
@@ -49,9 +49,8 @@ class ICallPromotionAnalysis {
   /// Returns reference to array of InstrProfValueData for the given
   /// instruction \p I.
   ///
-  /// The \p NumVals, \p TotalCount and \p NumCandidates
-  /// are set to the number of values in the array, the total profile count
-  /// of the indirect call \p I, and the number of profitable candidates
+  /// The \p TotalCount and \p NumCandidates are set to the the total profile
+  /// count of the indirect call \p I and the number of profitable candidates
   /// in the given array (which is sorted in reverse order of profitability).
   ///
   /// The returned array space is owned by this class, and overwritten on

@teresajohnson teresajohnson merged commit 6175951 into llvm:main Sep 4, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm:analysis Includes value tracking, cost tables and constant folding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants