[MLIR][Python] Fix detached operation coming from IfOp constructor

[matth2k]

Without this fix, scf.if operations would be created without a parent. Since scf.if operations often have no results, this caused silent bugs where the generated code was straight-up missing the operation.

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-mlir

Author: Matt Hofmann (matth2k)

Changes

Without this fix, scf.if operations would be created without a parent. Since scf.if operations often have results, this caused silent bugs where the generated code was straight-up missing the operation.

---

Full diff: https://github.com/llvm/llvm-project/pull/107286.diff

1 Files Affected:

• (modified) mlir/python/mlir/dialects/scf.py (+1-1)

diff --git a/mlir/python/mlir/dialects/scf.py b/mlir/python/mlir/dialects/scf.py
index 7025f6e0f1a166..2d0047b76c7022 100644
--- a/mlir/python/mlir/dialects/scf.py
+++ b/mlir/python/mlir/dialects/scf.py
@@ -87,7 +87,7 @@ def __init__(self, cond, results_=None, *, hasElse=False, loc=None, ip=None):
         operands.append(cond)
         results = []
         results.extend(results_)
-        super().__init__(results, cond)
+        super().__init__(results, cond, loc=loc, ip=ip)
         self.regions[0].blocks.append(*[])
         if hasElse:
             self.regions[1].blocks.append(*[])

[github-actions]

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Discourse for more information.

[joker-eph]

Thanks for the contribution! Is this possible to add a test for this?

[matth2k]

Thanks for the contribution! Is this possible to add a test for this?

Just added one. Let's see if it passes CI.

[makslevental]

Thanks for the contribution! Is this possible to add a test for this?

Only way I can think of is to dump the module with debug info inlined and then # CHECK but it's very brittle obv (will have to be updated when imports change or function body gets shifted.

[makslevental]

Oh whoops didn't notice ip was being added/tested.

[github-actions]

✅ With the latest revision this PR passed the Python code formatter.

[makslevental]

Thanks for adding the test

[makslevental]

@matth2k if you need me to merge lmk

[github-actions]

@matth2k Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!