Skip to content

[Target] Use templated MachineFunction::getSubtarget in *CallingConv.td. NFC #107311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions llvm/lib/Target/AMDGPU/AMDGPUCallingConv.td
Original file line number Diff line number Diff line change
Expand Up @@ -214,13 +214,11 @@ def RetCC_AMDGPU_Func : CallingConv<[
]>;

def CC_AMDGPU : CallingConv<[
CCIf<"static_cast<const GCNSubtarget&>"
"(State.getMachineFunction().getSubtarget()).getGeneration() >= "
"AMDGPUSubtarget::SOUTHERN_ISLANDS",
CCIf<"State.getMachineFunction().getSubtarget<GCNSubtarget>().getGeneration() >= "
"AMDGPUSubtarget::SOUTHERN_ISLANDS",
CCDelegateTo<CC_SI_SHADER>>,
CCIf<"static_cast<const GCNSubtarget&>"
"(State.getMachineFunction().getSubtarget()).getGeneration() >= "
"AMDGPUSubtarget::SOUTHERN_ISLANDS && State.getCallingConv() == CallingConv::C",
CCIf<"State.getMachineFunction().getSubtarget<GCNSubtarget>().getGeneration() >= "
"AMDGPUSubtarget::SOUTHERN_ISLANDS && State.getCallingConv() == CallingConv::C",
CCDelegateTo<CC_AMDGPU_Func>>
]>;

Expand Down
4 changes: 2 additions & 2 deletions llvm/lib/Target/M68k/M68kCallingConv.td
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
// TODO Verify C convention follows SysV M68K ABI

class CCIfSubtarget<string F, CCAction A>
: CCIf<!strconcat("static_cast<const M68kSubtarget &>"
"(State.getMachineFunction().getSubtarget()).", F), A>;
: CCIf<!strconcat("State.getMachineFunction()."
"getSubtarget<M68kSubtarget>().", F), A>;

//===----------------------------------------------------------------------===//
// Return Value Calling Conventions
Expand Down
3 changes: 1 addition & 2 deletions llvm/lib/Target/Mips/MipsCallingConv.td
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@
/// CCIfSubtarget - Match if the current subtarget has a feature F.
class CCIfSubtarget<string F, CCAction A, string Invert = "">
: CCIf<!strconcat(Invert,
"static_cast<const MipsSubtarget&>"
"(State.getMachineFunction().getSubtarget()).",
"State.getMachineFunction().getSubtarget<MipsSubtarget>().",
F),
A>;

Expand Down
6 changes: 2 additions & 4 deletions llvm/lib/Target/PowerPC/PPCCallingConv.td
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,11 @@

/// CCIfSubtarget - Match if the current subtarget has a feature F.
class CCIfSubtarget<string F, CCAction A>
: CCIf<!strconcat("static_cast<const PPCSubtarget&>"
"(State.getMachineFunction().getSubtarget()).",
: CCIf<!strconcat("State.getMachineFunction().getSubtarget<PPCSubtarget>().",
F),
A>;
class CCIfNotSubtarget<string F, CCAction A>
: CCIf<!strconcat("!static_cast<const PPCSubtarget&>"
"(State.getMachineFunction().getSubtarget()).",
: CCIf<!strconcat("!State.getMachineFunction().getSubtarget<PPCSubtarget>().",
F),
A>;
class CCIfOrigArgWasNotPPCF128<CCAction A>
Expand Down
4 changes: 2 additions & 2 deletions llvm/lib/Target/SystemZ/SystemZCallingConv.td
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ class CCIfExtend<CCAction A>
: CCIf<"ArgFlags.isSExt() || ArgFlags.isZExt()", A>;

class CCIfSubtarget<string F, CCAction A>
: CCIf<!strconcat("static_cast<const SystemZSubtarget&>"
"(State.getMachineFunction().getSubtarget()).", F),
: CCIf<!strconcat("State.getMachineFunction()."
"getSubtarget<SystemZSubtarget>().", F),
A>;

// Match if this specific argument is a fixed (i.e. named) argument.
Expand Down
8 changes: 4 additions & 4 deletions llvm/lib/Target/X86/X86CallingConv.td
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@

/// CCIfSubtarget - Match if the current subtarget has a feature F.
class CCIfSubtarget<string F, CCAction A>
: CCIf<!strconcat("static_cast<const X86Subtarget&>"
"(State.getMachineFunction().getSubtarget()).", F),
: CCIf<!strconcat("State.getMachineFunction()."
"getSubtarget<X86Subtarget>().", F),
A>;

/// CCIfNotSubtarget - Match if the current subtarget doesn't has a feature F.
class CCIfNotSubtarget<string F, CCAction A>
: CCIf<!strconcat("!static_cast<const X86Subtarget&>"
"(State.getMachineFunction().getSubtarget()).", F),
: CCIf<!strconcat("!State.getMachineFunction()."
"getSubtarget<X86Subtarget>().", F),
A>;

/// CCIfRegCallv4 - Match if RegCall ABIv4 is respected.
Expand Down
Loading