[TableGen] Add check for number of intrinsic return values #107326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurahul
changed the title
jurahul
changed the title
|
Linux build failure in lldb test seems unrelated. Also, currently without this check, we hit the following assert: llvm-tblgen: /home/rjoshi/upstream_llvm/llvm-project/llvm/include/llvm/Support/Casting.h:578: decltype(auto) llvm::cast(From *) [To = llvm::ListInit, From = const llvm::Init]: Assertion `isa(Val) && "cast() argument of incompatible type!"' failed. That's because in : There is OOB indexing into the IIT_RetNumbers list, resulting in an unresolved record or something like that. |
arsenm
approved these changes
Sep 5, 2024
jurahul
force-pushed
the
intrinsic_num_rets_check
branch
from
6e0a65e to
3da448b
Compare
Fail if we see an intrinsic that returns more than the supported number of return values. Intrinsics can return only upto a certain nyumber of values, as defined by the `IIT_RetNumbers` list in Intrinsics.td. Currently, if we define an intrinsic that exceeds the limit, llvm-tblgen crashes. Instead, read this limit and fail its exceeded with a proper error message.
jurahul
force-pushed
the
intrinsic_num_rets_check
branch
from
3da448b to
a57bbb8
Compare
|
updated unit test to reflect the lowecase error message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fail if we see an intrinsic that returns more than the supported number of return values.
Intrinsics can return only upto a certain nyumber of values, as defined by the
IIT_RetNumberslist inIntrinsics.td. Currently, if we define an intrinsic that exceeds the limit, llvm-tblgen crashes. Instead, read this limit and fail if it's exceeded with a proper error message.