[TableGen] Add PrintError family overload that take a print function #107333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurahul
force-pushed
the
tablegen_print_error_enhancements
branch
from
8b259c0 to
d77449f
Compare
topperc
reviewed
Sep 5, 2024
jurahul
force-pushed
the
tablegen_print_error_enhancements
branch
from
d77449f to
ebbb869
Compare
jurahul
force-pushed
the
tablegen_print_error_enhancements
branch
from
ebbb869 to
1c93805
Compare
|
I removed the use of formatv() in the new code as it was simple enough to not warrant the need of formatv(). |
Add PrintError and family overload that accepts a print function. This avoids constructing potentially long strings for passing into these print functions.
jurahul
force-pushed
the
tablegen_print_error_enhancements
branch
from
1c93805 to
452c646
Compare
|
I also removed the "OpNo -= NumResults" refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PrintError and family overload that accepts a print function. This avoids constructing potentially long strings for passing into these print functions.