Skip to content

[SandboxIR][Bench] Test RAUW #107440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024
Merged

[SandboxIR][Bench] Test RAUW #107440

merged 1 commit into from
Sep 5, 2024

Conversation

vporpo
Copy link
Contributor

@vporpo vporpo commented Sep 5, 2024

No description provided.

@vporpo vporpo requested a review from alinas September 5, 2024 18:11
Copy link
Contributor

@alinas alinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some notes.

For future patches, consider if you can generate IR that can be reused between benchmarks. For example, the IR in generateRAUWIR could be used instead of generateBBWalkIR. The concern here being future code explosion and keeping the focus on what's being tested.

You can also have one where you aggregate some of the API being tested in a single benchmark.

@vporpo
Copy link
Contributor Author

vporpo commented Sep 5, 2024

consider if you can generate IR that can be reused between benchmarks.

We could reuse the same IR across a few tests, but in general tests require different IR, which is why the IR generation function is passed as a parameter to genIR().

@vporpo vporpo merged commit 362da64 into llvm:main Sep 5, 2024
6 of 8 checks passed
bogner added a commit that referenced this pull request Sep 8, 2024
In 362da64 "[SandboxIR][Bench] Test RAUW (#107440)" we started
using std::stringstream, but didn't include `<sstream>` for the
definition. This is resulting in a build failure on windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants