Skip to content

[lsp] Fix format string in Reply #107480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AmaranthineCodices
Copy link
Contributor

PR #105745 requires that formatv calls have the correct number of
arguments. This call to Logger::info was incorrect.

PR llvm#105745 requires that `formatv` calls have the correct number of
arguments. This call to `Logger::info` was incorrect.
@llvmbot llvmbot added mlir:core MLIR Core Infrastructure mlir labels Sep 5, 2024
@llvmbot
Copy link
Member

llvmbot commented Sep 5, 2024

@llvm/pr-subscribers-mlir-core

@llvm/pr-subscribers-mlir

Author: Lily Brown (AmaranthineCodices)

Changes

PR #105745 requires that formatv calls have the correct number of
arguments. This call to Logger::info was incorrect.


Full diff: https://github.com/llvm/llvm-project/pull/107480.diff

1 Files Affected:

  • (modified) mlir/lib/Tools/lsp-server-support/Transport.cpp (+1-1)
diff --git a/mlir/lib/Tools/lsp-server-support/Transport.cpp b/mlir/lib/Tools/lsp-server-support/Transport.cpp
index ca7ffdf78d3a1b..ad8308f69aead8 100644
--- a/mlir/lib/Tools/lsp-server-support/Transport.cpp
+++ b/mlir/lib/Tools/lsp-server-support/Transport.cpp
@@ -75,7 +75,7 @@ void Reply::operator()(llvm::Expected<llvm::json::Value> reply) {
     transport->reply(std::move(id), std::move(reply));
   } else {
     llvm::Error error = reply.takeError();
-    Logger::info("--> reply:{0}({1})", method, id, error);
+    Logger::info("--> reply:{0}({1}): {2}", method, id, error);
     transport->reply(std::move(id), std::move(error));
   }
 }

@River707
Copy link
Contributor

River707 commented Sep 6, 2024

Lily!

@Mogball Mogball merged commit e40c5b4 into llvm:main Sep 6, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mlir:core MLIR Core Infrastructure mlir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants