[flang][OpenMP] Don't abort when default is used on an invalid directive

[luporl]

The previous assert was not considering programs with semantic errors.

Fixes #107495
Fixes #93437

[llvmbot]

@llvm/pr-subscribers-flang-openmp

@llvm/pr-subscribers-flang-semantics

Author: Leandro Lupori (luporl)

Changes

The previous assert was not considering programs with semantic errors.

Fixes #107495

---

Full diff: https://github.com/llvm/llvm-project/pull/107586.diff

1 Files Affected:

• (modified) flang/lib/Semantics/resolve-directives.cpp (+3-1)

diff --git a/flang/lib/Semantics/resolve-directives.cpp b/flang/lib/Semantics/resolve-directives.cpp
index 4aecb8b8e7b479..01ce8d989fdd15 100644
--- a/flang/lib/Semantics/resolve-directives.cpp
+++ b/flang/lib/Semantics/resolve-directives.cpp
@@ -2152,7 +2152,9 @@ void OmpAttributeVisitor::CreateImplicitSymbols(
         dirContext.defaultDSA == Symbol::Flag::OmpShared) {
       // 1) default
       // Allowed only with parallel, teams and task generating constructs.
-      assert(parallelDir || taskGenDir || teamsDir);
+      if (!parallelDir && !taskGenDir && !teamsDir) {
+        return;
+      }
       if (dirContext.defaultDSA != Symbol::Flag::OmpShared)
         makePrivateSymbol(dirContext.defaultDSA);
       else

[luporl]

Now that I noticed that this is practically the same fix as in #93438.

[tblah]

Looks good.

I see this now hits a semantic error instead: "DEFAULT clause is not allowed on the DO directive". There doesn't seem to be a unit test for this currently. Please could you add one so we can verify that it doesn't crash.

[mjklemm]

LGTM

[NimishMishra]

Thanks @luporl . This looks good.