[SandboxIR] Add missing VectorType functions #107650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vporpo
reviewed
Sep 6, 2024
llvm/include/llvm/SandboxIR/Type.h
Outdated
| inline ElementCount getElementCount() const { | ||
| return cast<llvm::VectorType>(LLVMTy)->getElementCount(); | ||
| } | ||
| static VectorType *getInteger(Context &Ctx, VectorType *VTy); |
There was a problem hiding this comment.
We don't need the Ctx argument, you can get it like: VTy->getContext(). Same for the rest of the functions.
| EXPECT_TRUE(IVecTy->getElementType()->isIntegerTy(32)); | ||
| EXPECT_EQ(IVecTy->getElementCount(), FVecTy->getElementCount()); | ||
|
|
||
| auto *ExtVecTy = |
There was a problem hiding this comment.
nit: I usually add a comment mentioning the function being tested. This makes the test a bit more readable, especially in cases where you a check spans multiple lines of code. In this case something like // getExtendedVectorType
llvm/include/llvm/SandboxIR/Type.h
Outdated
| return VectorType::get(ElementType, | ||
| ElementCount::get(NumElements, Scalable)); | ||
| } | ||
| // Needs tests |
There was a problem hiding this comment.
Hmm which tests are missing?
There was a problem hiding this comment.
Delete stale comment
vporpo
reviewed
Sep 9, 2024
| EXPECT_TRUE(VecTy->getElementType()->isIntegerTy(16)); | ||
| EXPECT_EQ(VecTy->getElementCount(), ElementCount::getFixed(4)); | ||
|
|
||
| auto *FVecTy = cast<sandboxir::VectorType>(F->getArg(1)->getType()); |
There was a problem hiding this comment.
I think we are not testing the new get() functions:
// get(ElementType, NumElements, Scalable)
EXPECT_EQ(VectorType::get(Type::getInt16Ty(Ctx), 4, **/*Scalable=*/false), F>getArg(0)->getType());
// get(ElementType, Other)
EXPECT_EQ(VectorType::get(Type::getInt16Ty(Ctx), F->getArg(0)->getType()), F->getArg(0)->getType());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fills in many missing functions from VectorType