Skip to content

Fix build errors with a LLVM_ENABLE_MODULES=ON build #107654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2024
Merged

Fix build errors with a LLVM_ENABLE_MODULES=ON build #107654

merged 1 commit into from
Sep 7, 2024

Conversation

akyrtzi
Copy link
Contributor

@akyrtzi akyrtzi commented Sep 6, 2024

The errors fixed were:

  • llvm-project/llvm/include/llvm/Analysis/SyntheticCountsUtils.h:33:22: error: missing '#include <__fwd/vector.h>'; default argument of 'vector' must be defined before it is used
  • llvm-project/clang/include/clang/Tooling/Inclusions/StandardLibrary.h:41:15: error: missing '#include '; 'vector' must be declared before it is used
  • llvm-project/llvm/include/llvm/Transforms/InstCombine/InstCombiner.h:83:3: error: missing '#include "llvm/ADT/PostOrderIterator.h"'; 'ReversePostOrderTraversal' must be declared before it is used

@akyrtzi
Fix build errors with a LLVM_ENABLE_MODULES=ON build
c7a0351 
The errors fixed were:
* llvm-project/llvm/include/llvm/Analysis/SyntheticCountsUtils.h:33:22: error: missing '#include <__fwd/vector.h>'; default argument of 'vector' must be defined before it is used
* llvm-project/clang/include/clang/Tooling/Inclusions/StandardLibrary.h:41:15: error: missing '#include <vector>'; 'vector' must be declared before it is used
* llvm-project/llvm/include/llvm/Transforms/InstCombine/InstCombiner.h:83:3: error: missing '#include "llvm/ADT/PostOrderIterator.h"'; 'ReversePostOrderTraversal' must be declared before it is used
@llvmbot llvmbot added clang Clang issues not falling into any other category llvm:analysis Includes value tracking, cost tables and constant folding llvm:transforms labels Sep 6, 2024
@llvmbot
Copy link
Member

llvmbot commented Sep 6, 2024 •
edited
Loading

@llvm/pr-subscribers-llvm-transforms

@llvm/pr-subscribers-llvm-analysis

Author: Argyrios Kyrtzidis (akyrtzi)

Changes

The errors fixed were:

  • llvm-project/llvm/include/llvm/Analysis/SyntheticCountsUtils.h:33:22: error: missing '#include <__fwd/vector.h>'; default argument of 'vector' must be defined before it is used
  • llvm-project/clang/include/clang/Tooling/Inclusions/StandardLibrary.h:41:15: error: missing '#include <vector>'; 'vector' must be declared before it is used
  • llvm-project/llvm/include/llvm/Transforms/InstCombine/InstCombiner.h:83:3: error: missing '#include "llvm/ADT/PostOrderIterator.h"'; 'ReversePostOrderTraversal' must be declared before it is used

Full diff: https://github.com/llvm/llvm-project/pull/107654.diff

3 Files Affected:

  • (modified) clang/include/clang/Tooling/Inclusions/StandardLibrary.h (+1)
  • (modified) llvm/include/llvm/Analysis/SyntheticCountsUtils.h (+1)
  • (modified) llvm/include/llvm/Transforms/InstCombine/InstCombiner.h (+1)
diff --git a/clang/include/clang/Tooling/Inclusions/StandardLibrary.h b/clang/include/clang/Tooling/Inclusions/StandardLibrary.h
index a39ceb520dcf8a..147f505ade0584 100644
--- a/clang/include/clang/Tooling/Inclusions/StandardLibrary.h
+++ b/clang/include/clang/Tooling/Inclusions/StandardLibrary.h
@@ -21,6 +21,7 @@
 #include "llvm/Support/raw_ostream.h"
 #include <optional>
 #include <string>
+#include <vector>
 
 namespace clang {
 class Decl;
diff --git a/llvm/include/llvm/Analysis/SyntheticCountsUtils.h b/llvm/include/llvm/Analysis/SyntheticCountsUtils.h
index 8b61ac5ed8ca22..d9a477b72451f3 100644
--- a/llvm/include/llvm/Analysis/SyntheticCountsUtils.h
+++ b/llvm/include/llvm/Analysis/SyntheticCountsUtils.h
@@ -16,6 +16,7 @@
 #include "llvm/ADT/GraphTraits.h"
 #include "llvm/ADT/STLFunctionalExtras.h"
 #include "llvm/Support/ScaledNumber.h"
+#include <vector>
 
 namespace llvm {
 
diff --git a/llvm/include/llvm/Transforms/InstCombine/InstCombiner.h b/llvm/include/llvm/Transforms/InstCombine/InstCombiner.h
index f5f16037bef893..87d0d98e691374 100644
--- a/llvm/include/llvm/Transforms/InstCombine/InstCombiner.h
+++ b/llvm/include/llvm/Transforms/InstCombine/InstCombiner.h
@@ -18,6 +18,7 @@
 #ifndef LLVM_TRANSFORMS_INSTCOMBINE_INSTCOMBINER_H
 #define LLVM_TRANSFORMS_INSTCOMBINE_INSTCOMBINER_H
 
+#include "llvm/ADT/PostOrderIterator.h"
 #include "llvm/Analysis/DomConditionCache.h"
 #include "llvm/Analysis/InstructionSimplify.h"
 #include "llvm/Analysis/TargetFolder.h"

@llvmbot
Copy link
Member

llvmbot commented Sep 6, 2024

@llvm/pr-subscribers-clang

Author: Argyrios Kyrtzidis (akyrtzi)

Changes

The errors fixed were:

  • llvm-project/llvm/include/llvm/Analysis/SyntheticCountsUtils.h:33:22: error: missing '#include <__fwd/vector.h>'; default argument of 'vector' must be defined before it is used
  • llvm-project/clang/include/clang/Tooling/Inclusions/StandardLibrary.h:41:15: error: missing '#include <vector>'; 'vector' must be declared before it is used
  • llvm-project/llvm/include/llvm/Transforms/InstCombine/InstCombiner.h:83:3: error: missing '#include "llvm/ADT/PostOrderIterator.h"'; 'ReversePostOrderTraversal' must be declared before it is used

Full diff: https://github.com/llvm/llvm-project/pull/107654.diff

3 Files Affected:

  • (modified) clang/include/clang/Tooling/Inclusions/StandardLibrary.h (+1)
  • (modified) llvm/include/llvm/Analysis/SyntheticCountsUtils.h (+1)
  • (modified) llvm/include/llvm/Transforms/InstCombine/InstCombiner.h (+1)
diff --git a/clang/include/clang/Tooling/Inclusions/StandardLibrary.h b/clang/include/clang/Tooling/Inclusions/StandardLibrary.h
index a39ceb520dcf8a..147f505ade0584 100644
--- a/clang/include/clang/Tooling/Inclusions/StandardLibrary.h
+++ b/clang/include/clang/Tooling/Inclusions/StandardLibrary.h
@@ -21,6 +21,7 @@
 #include "llvm/Support/raw_ostream.h"
 #include <optional>
 #include <string>
+#include <vector>
 
 namespace clang {
 class Decl;
diff --git a/llvm/include/llvm/Analysis/SyntheticCountsUtils.h b/llvm/include/llvm/Analysis/SyntheticCountsUtils.h
index 8b61ac5ed8ca22..d9a477b72451f3 100644
--- a/llvm/include/llvm/Analysis/SyntheticCountsUtils.h
+++ b/llvm/include/llvm/Analysis/SyntheticCountsUtils.h
@@ -16,6 +16,7 @@
 #include "llvm/ADT/GraphTraits.h"
 #include "llvm/ADT/STLFunctionalExtras.h"
 #include "llvm/Support/ScaledNumber.h"
+#include <vector>
 
 namespace llvm {
 
diff --git a/llvm/include/llvm/Transforms/InstCombine/InstCombiner.h b/llvm/include/llvm/Transforms/InstCombine/InstCombiner.h
index f5f16037bef893..87d0d98e691374 100644
--- a/llvm/include/llvm/Transforms/InstCombine/InstCombiner.h
+++ b/llvm/include/llvm/Transforms/InstCombine/InstCombiner.h
@@ -18,6 +18,7 @@
 #ifndef LLVM_TRANSFORMS_INSTCOMBINE_INSTCOMBINER_H
 #define LLVM_TRANSFORMS_INSTCOMBINE_INSTCOMBINER_H
 
+#include "llvm/ADT/PostOrderIterator.h"
 #include "llvm/Analysis/DomConditionCache.h"
 #include "llvm/Analysis/InstructionSimplify.h"
 #include "llvm/Analysis/TargetFolder.h"

vsapsai
vsapsai approved these changes Sep 7, 2024
View reviewed changes
Copy link
Collaborator

@vsapsai vsapsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these!

@akyrtzi akyrtzi merged commit 9a84afe into llvm:main Sep 7, 2024
12 checks passed
@akyrtzi akyrtzi deleted the akyrtzi/pr/fix-modules-build branch September 7, 2024 02:57
benlangmuir pushed a commit to benlangmuir/llvm-project that referenced this pull request Mar 10, 2025
@akyrtzi @benlangmuir
Fix build errors with a LLVM_ENABLE_MODULES=ON build (llvm#107654)
3281833 
The errors fixed were:
* llvm-project/llvm/include/llvm/Analysis/SyntheticCountsUtils.h:33:22:
error: missing '#include <__fwd/vector.h>'; default argument of 'vector'
must be defined before it is used
*
llvm-project/clang/include/clang/Tooling/Inclusions/StandardLibrary.h:41:15:
error: missing '#include <vector>'; 'vector' must be declared before it
is used
*
llvm-project/llvm/include/llvm/Transforms/InstCombine/InstCombiner.h:83:3:
error: missing '#include "llvm/ADT/PostOrderIterator.h"';
'ReversePostOrderTraversal' must be declared before it is used

(cherry picked from commit 9a84afe)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsapsai vsapsai vsapsai approved these changes

@jansvoboda11 jansvoboda11 jansvoboda11 approved these changes

Assignees
No one assigned
Labels
clang Clang issues not falling into any other category llvm:analysis Includes value tracking, cost tables and constant folding llvm:transforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@akyrtzi @llvmbot @vsapsai @jansvoboda11