Skip to content

[AMDGPU] Remove unnecessary untieRegOperand #107695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

jayfoad
Copy link
Contributor

@jayfoad jayfoad commented Sep 7, 2024

As far as I can tell, V_SET_INACTIVE has never had tied operands.

As far as I can tell, V_SET_INACTIVE has never had tied operands.
@llvmbot
Copy link
Member

llvmbot commented Sep 7, 2024

@llvm/pr-subscribers-backend-amdgpu

Author: Jay Foad (jayfoad)

Changes

As far as I can tell, V_SET_INACTIVE has never had tied operands.


Full diff: https://github.com/llvm/llvm-project/pull/107695.diff

1 Files Affected:

  • (modified) llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp (-1)
diff --git a/llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp b/llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp
index bc4b1936cb7e38..f9d7ead4ff3ecc 100644
--- a/llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp
+++ b/llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp
@@ -1534,7 +1534,6 @@ bool SIWholeQuadMode::lowerCopyInstrs() {
       if (MI->getOperand(2).isReg())
         RecomputeReg = MI->getOperand(2).getReg();
       MI->removeOperand(2);
-      MI->untieRegOperand(1);
     } else {
       assert(MI->getNumExplicitOperands() == 2);
     }

Copy link
Contributor

@perlfu perlfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jayfoad jayfoad merged commit 1d44ecb into llvm:main Sep 8, 2024
10 checks passed
@jayfoad jayfoad deleted the remove-untieregoperand branch September 8, 2024 07:21
@llvm-ci
Copy link
Collaborator

llvm-ci commented Sep 8, 2024

LLVM Buildbot has detected a new failure on builder clang-x86_64-debian-fast running on gribozavr4 while building llvm at step 6 "test-build-unified-tree-check-all".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/56/builds/6805

Here is the relevant piece of the build log for the reference
Step 6 (test-build-unified-tree-check-all) failure: 1200 seconds without output running [b'ninja', b'check-all'], attempting to kill
...
PASS: LLVM :: tools/llvm-reduce/remove-instructions.ll (80056 of 80066)
PASS: lit :: googletest-timeout.py (80057 of 80066)
PASS: lit :: selecting.py (80058 of 80066)
PASS: lit :: shtest-timeout.py (80059 of 80066)
PASS: LLVM-Unit :: Support/./SupportTests/127/173 (80060 of 80066)
PASS: lit :: max-time.py (80061 of 80066)
PASS: lit :: shtest-shell.py (80062 of 80066)
PASS: lit :: shtest-define.py (80063 of 80066)
PASS: LLVM-Unit :: Support/./SupportTests/125/173 (80064 of 80066)
PASS: LLVM :: tools/llvm-reduce/parallel-workitem-kill.ll (80065 of 80066)
command timed out: 1200 seconds without output running [b'ninja', b'check-all'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=1415.449462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants