Skip to content

[SandboxIR][Bench] Fix build #107699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2024
Merged

[SandboxIR][Bench] Fix build #107699

merged 1 commit into from
Sep 9, 2024

Conversation

GkvJwa
Copy link
Contributor

@GkvJwa GkvJwa commented Sep 7, 2024

Add header files(sstream), so that msvc can be compiled normally.

1>SandboxIRBench.cpp
1>benchmarks\SandboxIRBench.cpp(68,21): error C2079: 'SS' uses undefined class 'std::basic_stringstream<char,std::char_traits,std::allocator>'
1>benchmarks\SandboxIRBench.cpp(69,6): error C2297: '<<': not valid as right operand has type 'const char [38]'
1>benchmarks\SandboxIRBench.cpp(69,6): warning C4552: '<<': result of expression not used
1>benchmarks\SandboxIRBench.cpp(71,8): error C2297: '<<': not valid as right operand has type 'const char [7]'
1>benchmarks\SandboxIRBench.cpp(71,27): error C2297: '<<': not valid as right operand has type 'const char [21]'
1>benchmarks\SandboxIRBench.cpp(71,27): warning C4552: '<<': result of expression not used
1>benchmarks\SandboxIRBench.cpp(72,6): error C2297: '<<': not valid as right operand has type 'const char [9]'
1>benchmarks\SandboxIRBench.cpp(72,6): warning C4552: '<<': result of expression not used
1>benchmarks\SandboxIRBench.cpp(73,6): error C2297: '<<': not valid as right operand has type 'const char [2]'
1>benchmarks\SandboxIRBench.cpp(73,6): warning C4552: '<<': result of expression not used
1>benchmarks\SandboxIRBench.cpp(110,21): error C2079: 'SS' uses undefined class 'std::basic_stringstream<char,std::char_traits,std::allocator>'
1>benchmarks\SandboxIRBench.cpp(111,6): error C2297: '<<': not valid as right operand has type 'const char [38]'
1>benchmarks\SandboxIRBench.cpp(111,6): warning C4552: '<<': result of expression not used
1>benchmarks\SandboxIRBench.cpp(112,6): error C2297: '<<': not valid as right operand has type 'const char [28]'
1>benchmarks\SandboxIRBench.cpp(112,6): warning C4552: '<<': result of expression not used
1>benchmarks\SandboxIRBench.cpp(113,6): error C2297: '<<': not valid as right operand has type 'const char [28]'
1>benchmarks\SandboxIRBench.cpp(113,6): warning C4552: '<<': result of expression not used
1>benchmarks\SandboxIRBench.cpp(115,8): error C2297: '<<': not valid as right operand has type 'const char [7]'
1>benchmarks\SandboxIRBench.cpp(115,27): error C2297: '<<': not valid as right operand has type 'const char [25]'
1>benchmarks\SandboxIRBench.cpp(115,27): warning C4552: '<<': result of expression not used
1>benchmarks\SandboxIRBench.cpp(116,6): error C2297: '<<': not valid as right operand has type 'const char [9]'
1>benchmarks\SandboxIRBench.cpp(116,6): warning C4552: '<<': result of expression not used
1>benchmarks\SandboxIRBench.cpp(117,6): error C2297: '<<': not valid as right operand has type 'const char [2]'
1>benchmarks\SandboxIRBench.cpp(117,6): warning C4552: '<<': result of expression not used

@GkvJwa
Copy link
Contributor Author

GkvJwa commented Sep 7, 2024

Hello @vporpo, can help review it?

@tschuett tschuett requested a review from vporpo September 7, 2024 15:04
Copy link
Contributor

@vporpo vporpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it looks good, thanks for the fix!

@GkvJwa
Copy link
Contributor Author

GkvJwa commented Sep 8, 2024

I guess it looks good, thanks for the fix!

Okay, Help me merge it

@GkvJwa GkvJwa merged commit 738abb9 into llvm:main Sep 9, 2024
9 checks passed
@GkvJwa
Copy link
Contributor Author

GkvJwa commented Sep 9, 2024

I guess it looks good, thanks for the fix!

Okay, Help me merge it

After having permission, I didn't notice that someone had edited the file to fix this, which resulted in an empty commit after I merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants