Skip to content

[NFC][TableGen] Replace DefInit::get() with Record::getDefInit() #107762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

jurahul
Copy link
Contributor

@jurahul jurahul commented Sep 8, 2024

Eliminate DefInit::get() as its a duplicate of Record::getDefInit().
Use early return in VarDefInit::instantiate.

Copy link

github-actions bot commented Sep 8, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

Eliminate DefInit::get() as its a duplicate of Record::getDefInit().
Use early return in `VarDefInit::instantiate`.
@jurahul jurahul force-pushed the eliminate_duplicate_definit_get branch from df6640d to 5936683 Compare September 8, 2024 15:49
@jurahul jurahul marked this pull request as ready for review September 8, 2024 17:38
Copy link
Contributor

@kazutakahirata kazutakahirata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jurahul jurahul merged commit ce3c58e into llvm:main Sep 8, 2024
10 checks passed
@jurahul jurahul deleted the eliminate_duplicate_definit_get branch September 8, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants