[LoopUnswitch] Remove redundant condition. (NFC)

[AmrDeveloper]

Remove redundant condition from '!A || (A && B)' to '!A || B'

Fixes: #99799

[llvmbot]

@llvm/pr-subscribers-llvm-transforms

Author: Amr Hesham (AmrDeveloper)

Changes

Remove redundant condition from '!A || (A && B)' to '!A || B'

Fixes: #99799

---

Full diff: https://github.com/llvm/llvm-project/pull/107893.diff

1 Files Affected:

• (modified) llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp (+1-2)

diff --git a/llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp b/llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp
index c235d2fb2a5bd4..7d87df1805d1ea 100644
--- a/llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp
+++ b/llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp
@@ -770,8 +770,7 @@ static bool unswitchTrivialSwitch(Loop &L, SwitchInst &SI, DominatorTree &DT,
     // instruction in the block.
     auto *TI = BBToCheck.getTerminator();
     bool isUnreachable = isa<UnreachableInst>(TI);
-    return !isUnreachable ||
-           (isUnreachable && (BBToCheck.getFirstNonPHIOrDbg() != TI));
+    return !isUnreachable || (BBToCheck.getFirstNonPHIOrDbg() != TI);
   };
 
   SmallVector<int, 4> ExitCaseIndices;

[fhahn]

Thanks for the patch. Would be good to update the title to be more precise, e.g. something like [LoopUnswitch] Remove redundant condition. (NFC)

[fhahn]

Suggested change

	return !isUnreachable || (BBToCheck.getFirstNonPHIOrDbg() != TI);
	return !isUnreachable || BBToCheck.getFirstNonPHIOrDbg() != TI;

[AmrDeveloper]

Sure i will update it now, thanks

[AmrDeveloper]

Done

[fhahn]

LGTM, thanks!