Add myself as the PS4/PS5 code owner #108002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pogo59
reviewed
Sep 10, 2024
llvm/CODE_OWNERS.TXT
Outdated
| D: Sony PlayStation®4 support | ||
| N: Jeremy Morse | ||
| E: jeremy.morse@sony.com | ||
| D: Sony PlayStation®4 and PlayStation®5 support |
There was a problem hiding this comment.
The entries should be sorted by surname, please move the new entry.
|
Switched to the new Maintainers.md format; it no longer appears to be surname ordered, instead PS things land in "other". |
pogo59
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
LGTM, although probably there should also be an entry in clang/CodeOwners.rst, as we--uh, Sony has a bunch of code sprinkled through Clang (driver target, lots of fiddly bits here and there, and a special case almost everywhere that there's an ABI difference to decide on).
|
For the clang Maintainers.md, I figure it's worth chatting to folks at the conference to see whether that's seen as worthwhile (I don't see other target-specific entries there). |
DanielCChen
pushed a commit
to DanielCChen/llvm-project
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here: https://discourse.llvm.org/t/new-ps4-ps5-code-owner/80901