Skip to content

[HLSL] fix elementwise bitreverse test #108128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

spall
Copy link
Contributor

@spall spall commented Sep 11, 2024

The test called 'ceil' instead of 'bitreverse', which I assume was a copy paste leftover.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Sep 11, 2024
@llvmbot
Copy link
Member

llvmbot commented Sep 11, 2024

@llvm/pr-subscribers-clang

Author: Sarah Spall (spall)

Changes

The test called 'ceil' instead of 'bitreverse', which I assume was a copy paste leftover.


Full diff: https://github.com/llvm/llvm-project/pull/108128.diff

1 Files Affected:

  • (modified) clang/test/Sema/builtins-elementwise-math.c (+2-2)
diff --git a/clang/test/Sema/builtins-elementwise-math.c b/clang/test/Sema/builtins-elementwise-math.c
index 2673f1f519af69..628274380ae5f2 100644
--- a/clang/test/Sema/builtins-elementwise-math.c
+++ b/clang/test/Sema/builtins-elementwise-math.c
@@ -275,8 +275,8 @@ void test_builtin_elementwise_min(int i, short s, double d, float4 v, int3 iv, u
 
 void test_builtin_elementwise_bitreverse(int i, float f, double d, float4 v, int3 iv, unsigned u, unsigned4 uv) {
 
-  struct Foo s = __builtin_elementwise_ceil(f);
-  // expected-error@-1 {{initializing 'struct Foo' with an expression of incompatible type 'float'}}
+  struct Foo s = __builtin_elementwise_bitreverse(i);
+  // expected-error@-1 {{initializing 'struct Foo' with an expression of incompatible type 'int'}}
 
   i = __builtin_elementwise_bitreverse();
   // expected-error@-1 {{too few arguments to function call, expected 1, have 0}}

@spall spall force-pushed the bitreverse-test-fix branch from 86e24b5 to 8146b03 Compare September 11, 2024 18:24
@bogner bogner merged commit d32982b into llvm:main Sep 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants