Skip to content

[NFC] Fix an inaccurate comment about typo-correction. #108143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

mpark
Copy link
Member

@mpark mpark commented Sep 11, 2024

The comment describes "If the identifier was typo-corrected", but it doesn't need to have been typo-corrected, just being annotated is enough to retry.

The comment describes "If the identifier was typo-corrected",
but it doesn't need to have been typo-corrected, just being
annotated is enough to retry.
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" labels Sep 11, 2024
@llvmbot
Copy link
Member

llvmbot commented Sep 11, 2024

@llvm/pr-subscribers-clang

Author: Michael Park (mpark)

Changes

The comment describes "If the identifier was typo-corrected", but it doesn't need to have been typo-corrected, just being annotated is enough to retry.


Full diff: https://github.com/llvm/llvm-project/pull/108143.diff

1 Files Affected:

  • (modified) clang/lib/Parse/ParseStmt.cpp (+1-1)
diff --git a/clang/lib/Parse/ParseStmt.cpp b/clang/lib/Parse/ParseStmt.cpp
index bdb3fc051d0b35..9188799fce13e6 100644
--- a/clang/lib/Parse/ParseStmt.cpp
+++ b/clang/lib/Parse/ParseStmt.cpp
@@ -228,7 +228,7 @@ StmtResult Parser::ParseStatementOrDeclarationAfterAttributes(
         return StmtError();
       }
 
-      // If the identifier was typo-corrected, try again.
+      // If the identifier was annotated, try again.
       if (Tok.isNot(tok::identifier))
         goto Retry;
     }

@mpark mpark requested a review from cor3ntin September 11, 2024 17:15
@cor3ntin cor3ntin merged commit 64dba97 into llvm:main Sep 12, 2024
11 checks passed
@mpark mpark deleted the fix-annotation-comment branch September 12, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants