[lldb] Make sure TestDAP_subtleFrames actually uses libc++ #108227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, the binary would still be built with libstdc++, if that's the system/compiler default.
|
@llvm/pr-subscribers-lldb Author: Pavel Labath (labath) ChangesWithout this, the binary would still be built with libstdc++, if that's the system/compiler default. Full diff: https://github.com/llvm/llvm-project/pull/108227.diff 1 Files Affected:
diff --git a/lldb/test/API/tools/lldb-dap/stackTrace/subtleFrames/Makefile b/lldb/test/API/tools/lldb-dap/stackTrace/subtleFrames/Makefile
index 99998b20bcb050..ab034edd121f9f 100644
--- a/lldb/test/API/tools/lldb-dap/stackTrace/subtleFrames/Makefile
+++ b/lldb/test/API/tools/lldb-dap/stackTrace/subtleFrames/Makefile
@@ -1,3 +1,4 @@
CXX_SOURCES := main.cpp
+USE_LIBCPP := 1
include Makefile.rules
|
Michael137
approved these changes
Sep 11, 2024
vogelsgesang
approved these changes
Sep 12, 2024
adrian-prantl
pushed a commit
to adrian-prantl/llvm-project
that referenced
this pull request
Dec 20, 2024
Without this, the binary would still be built with libstdc++, if that's the system/compiler default. (cherry picked from commit 069b841)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, the binary would still be built with libstdc++, if that's the system/compiler default.