Skip to content

[mlir][bufferization] Fix OpFilter::denyDialect #108249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

mfrancio
Copy link
Contributor

The implementation would crash with unloaded dialects.

The implementation would crash with unloaded dialects.
@llvmbot llvmbot added mlir mlir:bufferization Bufferization infrastructure labels Sep 11, 2024
@llvmbot
Copy link
Member

llvmbot commented Sep 11, 2024

@llvm/pr-subscribers-mlir-bufferization

@llvm/pr-subscribers-mlir

Author: Matteo Franciolini (mfrancio)

Changes

The implementation would crash with unloaded dialects.


Full diff: https://github.com/llvm/llvm-project/pull/108249.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h (+1-1)
diff --git a/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h b/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h
index 2fda091e412aef..aceb9d059b95f3 100644
--- a/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h
+++ b/mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h
@@ -152,7 +152,7 @@ class OpFilter {
   /// This function adds a DENY entry.
   void denyDialect(StringRef dialectNamespace) {
     Entry::FilterFn filterFn = [=](Operation *op) {
-      return op->getDialect()->getNamespace() == dialectNamespace;
+      return op->getName().getDialectNamespace() == dialectNamespace;
     };
     entries.push_back(Entry{filterFn, Entry::FilterType::DENY});
   }

@mfrancio mfrancio changed the title The implementation would crash with unloaded dialects. [mlir][bufferization] Fix OpFilter::denyDialect. Sep 11, 2024
@mfrancio mfrancio changed the title [mlir][bufferization] Fix OpFilter::denyDialect. [mlir][bufferization] Fix OpFilter::denyDialect Sep 11, 2024
@mfrancio mfrancio merged commit aabb012 into llvm:main Sep 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mlir:bufferization Bufferization infrastructure mlir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants