Skip to content

[SandboxIR][Bench] SandboxIR creation #108278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[SandboxIR][Bench] SandboxIR creation #108278

merged 1 commit into from
Sep 11, 2024

Conversation

vporpo
Copy link
Contributor

@vporpo vporpo commented Sep 11, 2024

Adds a benchmark for the overhead of SandboxIR creation.

@alinas
Copy link
Contributor

alinas commented Sep 11, 2024

Can you rebase on top of #108273?

@vporpo
Copy link
Contributor Author

vporpo commented Sep 11, 2024

Can you rebase on top of #108273?

It is rebased as far as I can tell.

@alinas
Copy link
Contributor

alinas commented Sep 11, 2024

Can you update the names throughout the patch following that change?
s/SBox/SBoxNoTracking
s/SBoxTr/SBoxTracking

@vporpo
Copy link
Contributor Author

vporpo commented Sep 11, 2024

Oops let me fix them.

@@ -89,6 +89,31 @@ static std::string generateBBWalkIR(unsigned Size) {
return SS.str();
}

template <IR IRTy> static void SBoxIRCreation(benchmark::State &State) {
static_assert(IRTy != IR::LLVM, "Expected SBox and SBoxTr");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the assert message.

Adds a benchmark for the overhead of SandboxIR creation.
@vporpo vporpo merged commit 31d4837 into llvm:main Sep 11, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants