[lldb][testing] Check all stop reasons in get_threads_stopped_at_breakpoint_id #108281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kpoint_id If multiple breakpoints are hit at the same time, multiple stop reasons are reported, one per breakpoint. Currently, `get_threads_stopped_at_breakpoint_id` only checks the first such reason.
|
@llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) ChangesIf multiple breakpoints are hit at the same time, multiple stop reasons are reported, one per breakpoint. Currently, Full diff: https://github.com/llvm/llvm-project/pull/108281.diff 1 Files Affected:
diff --git a/lldb/packages/Python/lldbsuite/test/lldbutil.py b/lldb/packages/Python/lldbsuite/test/lldbutil.py
index 629565b38ca1e6..660a3c085a908a 100644
--- a/lldb/packages/Python/lldbsuite/test/lldbutil.py
+++ b/lldb/packages/Python/lldbsuite/test/lldbutil.py
@@ -773,9 +773,16 @@ def get_threads_stopped_at_breakpoint_id(process, bpid):
return threads
for thread in stopped_threads:
- # Make sure we've hit our breakpoint...
- break_id = thread.GetStopReasonDataAtIndex(0)
- if break_id == bpid:
+ # Make sure we've hit our breakpoint.
+ # From the docs of GetStopReasonDataAtIndex: "Breakpoint stop reasons
+ # will have data that consists of pairs of breakpoint IDs followed by
+ # the breakpoint location IDs".
+ # Iterate over all such pairs looking for `bpid`.
+ break_ids = [
+ thread.GetStopReasonDataAtIndex(idx)
+ for idx in range(0, thread.GetStopReasonDataCount(), 2)
+ ]
+ if bpid in break_ids:
threads.append(thread)
return threads
|
|
I only hit this bug in a downstream test. It seems we don't directly test lldbutil, but none of the tests regress with this change, so we should be confident it is correct. |
felipepiovezan
added a commit
to felipepiovezan/llvm-project
that referenced
this pull request
Sep 12, 2024
…kpoint_id (llvm#108281) If multiple breakpoints are hit at the same time, multiple stop reasons are reported, one per breakpoint. Currently, `get_threads_stopped_at_breakpoint_id` only checks the first such reason. (cherry picked from commit 7e74472)
felipepiovezan
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Sep 12, 2024
…le_reasons [cherry-pick][lldb][testing] Check all stop reasons in get_threads_stopped_at_breakpoint_id (llvm#108281)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If multiple breakpoints are hit at the same time, multiple stop reasons are reported, one per breakpoint.
Currently,
get_threads_stopped_at_breakpoint_idonly checks the first such reason.